- Notifications
You must be signed in to change notification settings - Fork897
Add missing milestone tocreate_issue#88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds support for a missing milestone parameter in the create_issue functionality to fix an issue with milestone handling. Key changes include:
- Adding "milestone" to the tool's input schema in tests.
- Updating the mock issue to include a milestone value.
- Incorporating an optional milestone parameter in the issue creation logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/github/issues_test.go | Adds assertions and test cases for milestone. |
| pkg/github/issues.go | Integrates optional milestone parameter into issue creation. |
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused.Learn more
Uh oh!
There was an error while loading.Please reload this page.
pkg/github/issues.go Outdated
| @@ -261,6 +261,9 @@ func createIssue(client *github.Client, t translations.TranslationHelperFunc) (t | |||
| }, | |||
| ), | |||
| ), | |||
| mcp.WithNumber("milestone", | |||
| mcp.Description("New milestone number"), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is it new or can it be an existing milestone number that attaches the new issue to the existing milestone?
b5f7301 to254be46Compare254be46 to135754aCompare95c7b0a intomainUh oh!
There was an error while loading.Please reload this page.
Description
Fixes#78