- Notifications
You must be signed in to change notification settings - Fork899
Enumerate strings in schema#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR restricts the possible string values for several search parameters by adding enum validations, addressing issue#79.
- Added mcp.Enum validations for sort order in searchCode and searchUsers.
- Introduced mcp.Enum for various fields (sort, order, state, etc.) in searchIssues and listIssues to restrict accepted values.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/search.go | Added enums to enforce allowed values for 'order' parameters. |
| pkg/github/issues.go | Introduced enums for fields such as 'sort', 'order', and 'state'. |
Comments suppressed due to low confidence (1)
pkg/github/issues.go:150
- The enum value 'reactions-+1' appears ambiguous and may be a typo. Consider verifying if it should be 'reactions+1' for clarity and consistency.
"reactions-+1",Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab.Learn more
2118e2a to76e3ff4Compare76e3ff4 to0c45320CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
e9bf1f1 toe406c0fCompare6b13742 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Description
Fixes#79
Reviewer Notes
This has no tests. We should consider adding some to validate they don't change unexpectedly, but let's split that into a separate issue.