- Notifications
You must be signed in to change notification settings - Fork897
chore: update deps#76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+88 −11,341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates and streamlines our third‐party dependencies by removing several vendored files from the HashiCorp HCL package and updating license entries to reflect new dependency versions. Key changes include:
- Removal of various HCL source files and associated tests.
- Updates to dependency versions and corresponding license references in third-party-licenses.md.
- Removal of ancillary files such as README.md and ISSUE_TEMPLATE.md.
Reviewed Changes
Copilot reviewed 197 out of 206 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| third-party/github.com/hashicorp/hcl/hcl/fmtcmd/fmtcmd.go | Entire file removed – verify no build dependencies rely on this. |
| third-party/github.com/hashicorp/hcl/hcl/ast/walk.go | Entire file removed – confirm that AST walking functionality is not affected. |
| third-party/github.com/hashicorp/hcl/hcl/ast/ast_test.go | Test file removed – ensure that test coverage for AST functionality is maintained elsewhere. |
| third-party/github.com/hashicorp/hcl/hcl/ast/ast.go | Core AST file removed – check that updated dependencies provide the necessary AST support. |
| third-party/github.com/hashicorp/hcl/hcl.go | Main HCL file removed – confirm that downstream usage isn’t inadvertently broken. |
| third-party-licenses.md | Multiple license entries updated to new dependency versions – ensure consistency and compliance. |
| third-party/github.com/hashicorp/hcl/README.md and .github/ISSUE_TEMPLATE.md | Ancillary documentation files removed – verify that documentation is maintained in alternate locations if needed. |
Files not reviewed (9)
- go.mod: Language not supported
- third-party/github.com/hashicorp/hcl/.gitignore: Language not supported
- third-party/github.com/hashicorp/hcl/.travis.yml: Language not supported
- third-party/github.com/hashicorp/hcl/LICENSE: Language not supported
- third-party/github.com/hashicorp/hcl/Makefile: Language not supported
- third-party/github.com/hashicorp/hcl/appveyor.yml: Language not supported
- third-party/github.com/hashicorp/hcl/go.mod: Language not supported
- third-party/github.com/hashicorp/hcl/hcl/fmtcmd/test-fixtures/.hidden.ignore: Language not supported
- third-party/github.com/hashicorp/hcl/hcl/fmtcmd/test-fixtures/file.ignore: Language not supported
Comments suppressed due to low confidence (7)
third-party/github.com/hashicorp/hcl/hcl/fmtcmd/fmtcmd.go:1
- The removal of fmtcmd.go could break references or build dependencies; please verify that its functionality is no longer required.
-// Derivative work from:third-party/github.com/hashicorp/hcl/hcl/ast/walk.go:1
- Removing walk.go may affect AST traversal capabilities; ensure that any dependent components are updated accordingly.
-package astthird-party/github.com/hashicorp/hcl/hcl/ast/ast_test.go:1
- The removal of ast_test.go reduces test coverage for HCL AST functionality; please confirm that tests exist elsewhere to cover these areas.
-package astthird-party/github.com/hashicorp/hcl/hcl/ast/ast.go:1
- The removal of ast.go, a core file defining the HCL AST, could impact parsing functionality; verify that the updated dependency supplies full AST support.
-// Package ast declares the types used to represent syntax trees for HCLthird-party/github.com/hashicorp/hcl/hcl.go:1
- The removal of the top-level hcl.go file might affect downstream usage; please confirm that the new dependency structure meets all functional requirements.
-// Package hcl decodes HCL into usable Go structures.third-party-licenses.md:11
- Updated dependency versions (e.g., fsnotify from v1.7.0 to v1.8.0) need to be checked for consistency across the project; ensure all version updates are intentional and compliant.
+ - [github.com/fsnotify/fsnotify](https://pkg.go.dev/github.com/fsnotify/fsnotify) ([BSD-3-Clause](https://github.com/fsnotify/fsnotify/blob/v1.8.0/LICENSE))third-party-licenses.md:21
- Multiple dependency version updates are present; please verify that all new license references (including for mapstructure, cast, and others) are correct and integrated consistently.
+ - [github.com/sourcegraph/conc](https://pkg.go.dev/github.com/sourcegraph/conc) ([MIT](https://github.com/sourcegraph/conc/blob/v0.3.0/LICENSE))Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab.Learn more
williammartin approved these changesApr 3, 2025
559b3ff intomain 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull requestApr 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Update go deps and corresponding licences.
Changed one dep due to deprecation: