Movatterモバイル変換

Copy link

soisyourface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is awesome. For agemini-cli user that is just trying to get this MCP to work, this is very helpful.

Left a few thoughts on the command use and things.

docs/installation-guides/install-gemini-cli.md Outdated

		# Install GitHub MCP Server in Google Gemini CLI

		## Prerequisites
		1. Google Gemini CLI installed (see [Installation Options](#installation-options))

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

question: should a guide on installinggemini-cli be in here? or just a link to thegemini-cli github page for instructions?

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good question! I've kept a brief installation section for user convenience (just the basic commands for npm, npx, and Homebrew) but added a link to thehttps://github.com/google-gemini/gemini-cli for more detailed installation options. This way users get the essentials quickly but can dive deeper if needed. What do you think of this approach?

Copy link

soisyourfaceAug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

mostly just worried that this information falls behind and perhaps a link to gemini-cli's installation is more robust.

Copy link

ContributorAuthor

ipapapaAug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense, I have made a few changes to emphasize the official documentation link first - making it clear users should go there for up-to-date instructions.

Copy link

DinoChiesaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think the information for how to install Gemini CLI belongs here. AFAIK the analogous information is not in the README files for other tools. Eg for Windsurf, the install guide talks about how to install github-mcp-server for Windsurf, not how to install windsurf.

docs/installation-guides/install-gemini-cli.md Outdated


		1. Check MCP server status:
		```bash
		gemini-cli mcp status

Copy link

soisyourfaceAug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fix: i think the command isgemini and notgemini-cli.

also, there is nogemini mcp status command. the closest isgemini --prompt /mcp list.

for the tools agemini --prompt /tools

this is true for examples below. you'll need the--prompt flag.

Copy link

ContributorAuthor

ipapapaAug 2, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oups, this was my mistake. I am sorry for this and thank you for catching it. I will fix it below with a new commit.
✅ Changed all gemini-cli commands to gemini
✅ Fixedgemini mcp status togemini --prompt /mcp list
✅ Fixedgemini mcp list-tools togemini --prompt /tools
✅ Added--prompt flags where needed throughout the examples

Fix Gemini CLI command syntax and add remote server method

89ec9f5

- Replace all 'gemini-cli' commands with correct 'gemini' syntax- Fix verification commands to use '/mcp list' and '/tools' prompts- Add httpUrl remote server method as primary configuration option- Update config file paths from settings.json to config.json- Correct npx installation command syntax- Add link to official Gemini CLI documentationAddresses feedback from soisyourface in PR review.

Copy link

rica19ro commentedAug 2, 2025

Add installation guide for Google Gemini CLI
Include Docker and binary configuration options
Add authentication setup for Gemini API and Vertex AI
Update main README.md to include Gemini CLI in installation guides
Update installation guides index with Gemini CLI entry and support matrix
Follow established documentation patterns and security best practices
Closes:
#756

piyanutwat approved these changes

piyanutwat approved these changes

piyanutwat approved these changes

ipapapa added2 commits

August 3, 2025 14:04

Merge branch 'main' into add-gemini-cli-docs

526a6c1

Emphasize official Gemini CLI documentation link

0127628

Reduce detailed installation steps and direct users to official docs forup-to-date instructions, addressing reviewer feedback about maintainability.

DinoChiesa reviewed

docs/installation-guides/install-gemini-cli.md Outdated


		Gemini CLI uses a settings JSON file to configure MCP servers:

		- Global configuration: `~/.gemini/config.json`

Copy link

DinoChiesaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is it not settings.json ?

Copy link

ContributorAuthor

ipapapaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oups my mistake, I have fixed it:a6e2426

DinoChiesa reviewed

		## Installation Options

		Install Google Gemini CLI using your preferred method. For the most up-to-date installation instructions and troubleshooting, see the [official Gemini CLI documentation](https://github.com/google-gemini/gemini-cli).

Copy link

DinoChiesaAug 8, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Probably lines 11 through 41 are best left out of this README., which pertains to github-mcp-server. Install instructions for Germini CLI should remain in the README for Gemini CLI.

Copy link

ContributorAuthor

ipapapaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good point about lines 11-41. I removed the Gemini CLI installation and authentication sections to keep this focused on GitHub MCP Server setup. This is also consistent with our other installation guides.

DinoChiesa reviewed

docs/installation-guides/install-gemini-cli.md OutdatedShow resolvedHide resolved

DinoChiesa reviewed

docs/installation-guides/install-gemini-cli.md Outdated


		### Method 2: Local Docker Setup (Alternative)

		Important: The npm package `@modelcontextprotocol/server-github` is no longer supported as of April 2025. Use the official Docker image `ghcr.io/github/github-mcp-server` instead.

Copy link

DinoChiesaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

omit "Important: The npm package@modelcontextprotocol/server-github is no longer supported as of April 2025."

This doc page is being added in August 2025. No need to reference old stuff.

Copy link

ContributorAuthor

ipapapaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done:6bfae0d

DinoChiesa reviewed

		## Prerequisites
		1. Google Gemini CLI installed (see [Installation Options](#installation-options))
		2. [GitHub Personal Access Token](https://github.com/settings/personal-access-tokens/new) with appropriate scopes
		3. For local installation: [Docker](https://www.docker.com/) installed and running

Copy link

DinoChiesaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Or Podman. (https://podman.io)

Copy link

ContributorAuthor

ipapapaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have not used Podman but based on my quick check it has Docker command compatibility, so I have added it:79e0782

Copy link

DinoChiesaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In case there is any doubt.... I use podman with this server and with gemini-cli, and it works great - no surprise here.

DinoChiesa reviewed

docs/installation-guides/install-gemini-cli.md OutdatedShow resolvedHide resolved

DinoChiesa reviewed

docs/installation-guides/install-gemini-cli.md Outdated


		- Official repository: [github/github-mcp-server](https://github.com/github/github-mcp-server)
		- Docker image: `ghcr.io/github/github-mcp-server` (official and supported)
		- npm package: `@modelcontextprotocol/server-github` (deprecated as of April 2025 - no longer functional)

Copy link

DinoChiesaAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

omit

Copy link

ContributorAuthor

ipapapaAug 8, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done, I have removed the deprecatednpm package in this commit6bfae0d

DinoChiesa suggested changes

Copy link

DinoChiesa left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for doing this.
I left a bunch of comments.

ipapapa added4 commits

August 8, 2025 04:32

Fix Gemini CLI configuration file name: config.json -> settings.json

a6e2426

The correct configuration file for Gemini CLI is settings.json, not config.json.This applies to both global (~/.gemini/settings.json) and project-specific(.gemini/settings.json) configurations as confirmed by official documentation.

Remove Gemini CLI installation and authentication sections

bc96391

Removed lines 11-41 containing Gemini CLI installation commands andauthentication setup instructions.

Add Podman as Docker alternative in prerequisites

79e0782

Added Podman as container engine option alongside Docker.

Remove references to deprecated npm package

6bfae0d

Copy link

DinoChiesa commentedAug 8, 2025

looking good

ipapapa added2 commits

August 8, 2025 10:53

Add comprehensive ~/.gemini/.env file example

c52a1de

Fix authorization header to use literal token placeholder

e5e7bfd

Environment variable substitution in headers is not yet supportedby Gemini CLI (seegoogle-gemini/gemini-cli#5282).

Copy link

ContributorAuthor

ipapapa commentedAug 8, 2025

@DinoChiesa I have addressed the comments above. Thank you so much for the amazing feedback, it helped a lot. Let me know if there is anything else that you might find useful. Otherwise, feel free to "approve" as a reviewer.

DinoChiesa mentioned this pull request

Gemini CLI is not performing environment variable substitution for MCP Serversgoogle-gemini/gemini-cli#5828

Open

DinoChiesa approved these changes

Docs/update gemini install guide#742

Copy link

ContributorAuthor

ipapapa commentedAug 9, 2025

@soisyourface is there any feedback that has not been addressed? Please let me if you approve for this work to finalize. Thank you!

mattdhollowayand others added8 commits

August 27, 2025 19:29

Add actions job log buffer and profiler (github#866)

fc381f8

* add sliding window for actions logs* refactor: fix sliding* remove trim content* only use up to 1mb of memory for logs* update to tail lines in second pass* add better memory usage calculation* increase window size to 5MB* update test* update vers* undo vers change* add incremental memory tracking* use ring buffer* remove unused ctx param* remove manual GC clear* fix cca feedback* extract ring buffer logic to new package* handle log content processing errors and use correct param for maxjobloglines* fix tailing* account for if tailLines exceeds window size* add profiling thats reusable* remove profiler testing* refactor profiler: introduce safeMemoryDelta for accurate memory delta calculations* linter fixes* Update pkg/buffer/buffer.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* use flag for maxJobLogLines* add param passing for context window size* refactor: rename contextWindowSize to contentWindowSize for consistency* fix: use tailLines if bigger but only if <= 5000* fix: limit tailLines to a maximum of 500 for log content download* Update cmd/github-mcp-server/main.goCo-authored-by: Adam Holt <omgitsads@github.com>* Update cmd/github-mcp-server/main.goCo-authored-by: Adam Holt <omgitsads@github.com>* move profiler to internal/* update actions test with new profiler location* fix: adjust buffer size limits* make line buffer 1028kb* fix mod path* change test to use same buffer size as normal use* improve test for non-sliding window implementation to not count empty lines* make test memory measurement more accurate* remove impossible conditional---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>Co-authored-by: Adam Holt <omgitsads@github.com>

Add get_release_by_tag tool (github#938)

615cc60

* add get_release_by_tag tool* add tool* add tests* autogen* remove comment

docs(readme): Update readme to point to correct installation guides i…

72a7214

…ndex (github#892)* docs(readme): Update readme to point to correct installation guides index* feat(contributors): add list_repository_contributors tool* Revert "feat(contributors): add list_repository_contributors tool"This reverts commitece480e.---------Co-authored-by: Tommaso Moro <37270480+tommaso-moro@users.noreply.github.com>

Add Global Security Advisories Toolset (github#919)

cd4454e

Repository security advisories (github#925)

ad3bf32

* Add support for listing repo level security advisories* Add support for listing repo security advisories at the org level

Update Cursor installation link (github#940)

6d4e070

* use new link* update local install link

Change role from "system" to "user" in prompt messages for `AssignCod…

b33df25

…ingAgentPrompt` and `IssueToFixWorkflowPrompt`. Role "system" is not allowed by Claude Code in MCP provided prompt (allowed only role "user" and "assistant") (github#941)Co-authored-by: 0xGosu <0xGosu@gmail.com>

Resolve merge conflict with latest upstream main

7acaad0

Copy link

soisyourface commentedAug 28, 2025

upstream in gemini-cli the bug was fixed concerning the.env loading.

LGTM

LuluBeatson self-assigned this

Aug 29, 2025

LuluBeatsonand others added3 commits

August 29, 2025 17:28

Merge branch 'main' into add-gemini-cli-docs

60fa301

Local MCP is supported

39db9e7

Refactor Gemini CLI install guide

ff86293

Copy link

Contributor

LuluBeatson commentedAug 29, 2025•
edited
Loading

Thank you@ipapapa for contributing this installation guide :)

I've made a few changes such as:

Re-ordering the sections so "Storing Your PAT Securely" is earlier and in the Prerequisites section (similar to structure of guide for Claude Code CLI)
Keeping the version of configs using$GITHUB_PAT, but removed duplicated configs requiring hardcoded PAT.
Removed additional configs with extra env vars. This info lives elsewhere as it's relevant to many host applications and IDEs. If it is not present, I will follow up to add it.
Fix in summary table to say that Local GitHub MCP is supported in Gemini CLI

LuluBeatson mentioned this pull request

Aug 29, 2025

Closed

rmedranollamas reviewed

Aug 29, 2025

		"httpUrl": "https://api.githubcopilot.com/mcp/",
		"trust": true,
		"headers": {
		"Authorization": "Bearer $GITHUB_PAT"

Copy link

rmedranollamasAug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

remove "Bearer"

Copy link

ContributorAuthor

ipapapaAug 29, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oups good catch. I fixed it:f2e5ad7

Copy link

rmedranollamas commentedAug 29, 2025

chiming in from#742 here -- i think this one will do (and includes the .env mechanism, which i don't). i am happily closing my PR, so we this one merged in.

Remove Bearer from Authorization header

f2e5ad7

saiqulhaq suggested changes

Aug 31, 2025


		</details>

		## GitHub MCP Server Configuration

Copy link

saiqulhaqAug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The installation could be outdated with the main README.md file
We should inform the user to see the README.md of this project for the latest config

Copy link

ContributorAuthor

ipapapaAug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added the note as requested:26d9139

Add reference to main README for latest config

26d9139

saiqulhaq approved these changes

Aug 31, 2025