- Notifications
You must be signed in to change notification settings - Fork1.4k
Bot#700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Ferdy2826 wants to merge3 commits intogithub:dependabot/go_modules/github.com/migueleliasweb/go-github-mock-1.4.0Choose a base branch fromFerdy2826:main
base:dependabot/go_modules/github.com/migueleliasweb/go-github-mock-1.4.0
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Bot#700
Ferdy2826 wants to merge3 commits intogithub:dependabot/go_modules/github.com/migueleliasweb/go-github-mock-1.4.0fromFerdy2826:main
+1,340 −249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* fix: Add SHA to get_file_contents while preserving MCP behavior (github#595)Enhance get_file_contents to include SHA information without changingthe existing MCP server response format.Changes:- Add Contents API call to retrieve SHA before fetching raw content- Include SHA in resourceURI (repo://owner/repo/sha/{SHA}/contents/path)- Add SHA to success messages- Update tests to verify SHA inclusion- Maintain original behavior: text files return raw text, binaries return base64This preserves backward compatibility while providing SHA informationfor better file versioning support.Closesgithub#595* fix: Improve error handling for Contents API responseEnsure response body is properly closed even when an error occurs by movingthe defer statement before the error check. This prevents potential resourceleaks when the Contents API returns an error with a non-nil response.Changes:- Move defer respContents.Body.Close() before error checking- Rename errContents to err for consistency- Add nil check for respContents before attempting to close bodyThis follows Go best practices for handling HTTP responses and preventspotential goroutine/memory leaks.* revert changes to resource URI* use GraphQL API to get file SHA* refactor: mock GQL client instead of getFileSHA function to follow conventions* lint* revert GraphQL---------Co-authored-by: LuluBeatson <lulubeatson@github.com>
… governance info for the github server (github#695)* Refactor README and add host installation guides, governance docs- Reorganized README for clarity and navigation- Added dedicated installation guides for Claude, Cursor, Windsurf, JetBrains, and more- Clarified contribution guidelines and approval criteria- Added policies and governance documentation* Update README.md* Update README with configuration section for remote GitHub MCP Server* Update MCP access policy description in READMERemoving coding agent from the policy note, as the GitHub server is unaffected by this policy* Update configuration steps for GitHub Copilot in JetBrains IDEs......to reflect changes in accessing settings and configuring MCP.* Update install-other-copilot-ides.md* Update Eclipse MCP support version and configuration steps......for GitHub Copilot plugin in installation guide.* Update docs/installation-guides/install-cursor.md* Update docs/installation-guides/install-windsurf.md* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg---------Co-authored-by: Tony Truong <tonytrg@github.com>
* shorten tool name* update function name to match tool name* adjust wording of descriptions
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: