- Notifications
You must be signed in to change notification settings - Fork1.4k
fix: shorten long tool name for adding pr review comments#697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+19 −19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR shortens the tool name fromadd_pull_request_review_comment_to_pending_review toadd_comment_to_pending_review to resolve a character limit issue in Cursor where tools with names exceeding 60 characters don't appear.
- Function name changed from
AddPullRequestReviewCommentToPendingReviewtoAddCommentToPendingReview - Tool name shortened from 49 to 29 characters while maintaining clarity
- Updated all references across tests, documentation, and end-to-end tests
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Updated function call to use new shortened tool name |
| pkg/github/pullrequests_test.go | Updated test assertions and function calls to match new naming |
| pkg/github/pullrequests.go | Renamed function and updated tool name, description, and translation keys |
| pkg/github/toolsnaps/add_comment_to_pending_review.snap | Updated snapshot with new tool name and descriptions |
| e2e/e2e_test.go | Updated end-to-end test calls to use new tool name |
| README.md | Updated documentation to reflect new tool name and description |
williammartin approved these changesJul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Passes e2e test:
➜ github-mcp-server git:(lulu/fix-long-name) ✗ GOMAXPROCS=1 GITHUB_MCP_SERVER_E2E_HOST=https://github.com GITHUB_MCP_SERVER_E2E_TOKEN=$(gh auth token) go test -v -count=1 --tags e2e -run 'TestPullRequestReviewCommentSubmit' ./e2e=== RUN TestPullRequestReviewCommentSubmit=== PAUSE TestPullRequestReviewCommentSubmit=== CONT TestPullRequestReviewCommentSubmit e2e_test.go:79: Building Docker image for e2e tests... e2e_test.go:162: Starting Stdio MCP client... e2e_test.go:1216: Getting current user... e2e_test.go:1245: Creating repository williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1269: Creating branch in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1286: Creating commit with new file in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1315: Creating pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1330: Creating pending review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1351: Adding file review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1371: Adding single line review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1393: Adding multi line review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1409: Submitting review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1423: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961... e2e_test.go:1254: Deleting repository williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1752830892961...--- PASS: TestPullRequestReviewCommentSubmit (19.09s)PASSok github.com/github/github-mcp-server/e2e 19.339sb5e3348 intomain 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Shorten tool name to
add_comment_to_pending_reviewReasoning:
Cursor has a limit of 60 characters for server name + tool name. Tools exceeding this don't show up.
add_pull_request_review_comment_to_pending_review(length 49 characters)add_comment_to_pending_review(length 29 characters)Closes:#582