- Notifications
You must be signed in to change notification settings - Fork1.4k
Add pagination support to GraphQL-based tools#683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mattdholloway wants to merge28 commits intomainChoose a base branch fromadd-pagination-graphql
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+441 −201
Open
Changes fromall commits
Commits
Show all changes
28 commits Select commitHold shift + click to select a range
2f95120
initial pagination for `ListDiscussions`
mattdhollowayd464ac1
redo category id var cast
mattdhollowayd745f5c
add GraphQL pagination support for discussion comments and categories
mattdholloway83c0a74
remove pageinfo returns
mattdhollowayf47e554
fix out ref for linter
mattdhollowayc9d6e1f
update docs
mattdholloway88f1255
Merge branch 'main' into add-pagination-graphql
mattdholloway9a08648
move to unified pagination for consensus on params
mattdholloway5c8b4a7
update docs
mattdholloway6bb5daf
refactor pagination handling
mattdholloway6d00394
update docs
mattdhollowayd2dd8f2
linter fix
mattdholloway3cab7b1
conv rest to gql params for safe lint
mattdhollowayf701670
add nolint
mattdholloway30e01f4
add error handling for perPage value in ToGraphQLParams
mattdhollowayb454926
refactor pagination error handling
mattdholloway98fd144
unified params for rest andn graphql and rennamed to be uniform for g…
mattdholloway1099990
add 'after' for pagination
mattdholloway752499b
update docs
mattdholloway548d4d7
Update pkg/github/discussions.go
mattdholloway592940e
Update pkg/github/discussions.go
mattdhollowayb09612e
Update pkg/github/discussions_test.go
mattdhollowaye21635c
update default page size const
mattdholloway2d36b04
Merge branch 'main' into add-pagination-graphql
mattdholloway985f8b2
reduce default pagination size from 100 to 30 in discussion tests
mattdholloway5d795ec
update pagination for reverse and total
mattdholloway7877d8d
update pagination to remove from discussions
mattdhollowayf870807
updated README
mattdhollowayFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.