Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add pagination support to GraphQL-based tools#683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mattdholloway merged 30 commits intomainfromadd-pagination-graphql
Jul 21, 2025

Conversation

mattdholloway
Copy link
Contributor

@mattdhollowaymattdholloway commentedJul 15, 2025•
edited
Loading

This PR idiomatically implements pagination for GraphQL based tools using the spec described inhttps://docs.github.com/en/graphql/reference/objects#connection and based on the standard inhttps://graphql.org/learn/pagination/

Closes:https://github.com/github/copilot-agent-services/issues/296

LuluBeatson reacted with rocket emoji
@mattdhollowaymattdholloway self-assigned thisJul 15, 2025
@mattdhollowaymattdholloway changed the titleinitial pagination forListDiscussionsAdd pagination support to GraphQL-based toolsJul 15, 2025
@mattdholloway
Copy link
ContributorAuthor

Pagination works for listing discussions but does not currently provide the caller with the details of which page it is on:

Screenshot 2025-07-15 at 16 45 33

@mattdhollowaymattdholloway marked this pull request as ready for reviewJuly 16, 2025 09:29
@CopilotCopilotAI review requested due to automatic review settingsJuly 16, 2025 09:29
@mattdhollowaymattdholloway requested a review froma team as acode ownerJuly 16, 2025 09:29
Copilot

This comment was marked as outdated.

Copilot

This comment was marked as outdated.

@mattdholloway
Copy link
ContributorAuthor

A downside of using cursor-based pagination in GraphQL is that there is no way of 'skipping' pages as the ID of the final entry of the previously - I am investigating falling back to the REST api if the user needs this functionality.

Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR implements pagination support for GraphQL-based tools to provide consistent pagination capabilities across both REST and GraphQL APIs. The changes introduce a unified pagination approach that accepts traditional page/perPage parameters while providing GraphQL cursor-based pagination support through theafter parameter.

Key changes include:

  • Introduction ofWithUnifiedPagination() function that adds page, perPage, and after parameters to GraphQL tools
  • Conversion of private pagination struct fields to public fields (Page, PerPage, After)
  • Addition ofToGraphQLParams() method to convert REST-style pagination to GraphQL parameters
  • Update of GraphQL discussion tools to return structured responses with pagination metadata

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
FileDescription
pkg/github/server.goAdds unified pagination support and GraphQL parameter conversion
pkg/github/discussions.goImplements pagination for all discussion-related GraphQL tools
pkg/github/discussions_test.goUpdates tests to handle new pagination response structure
pkg/github/server_test.goUpdates pagination tests for public struct fields
Multiple REST API filesUpdates field references from private to public pagination fields
README.mdDocuments new pagination parameters for discussion tools

mattdhollowayand others added5 commitsJuly 17, 2025 15:43
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mattdhollowaymattdholloway merged commit7ccc6b6 intomainJul 21, 2025
16 checks passed
@mattdhollowaymattdholloway deleted the add-pagination-graphql branchJuly 21, 2025 15:31
LuluBeatson added a commit that referenced this pull requestJul 22, 2025
* Create 'add sub-issue' tool* Fix hardcoded API host* Create 'list sub-issues' tool* Create 'remove sub-issue' tool* Fix Test_GetIssue mock data - add missing User fieldThe assertion was already checking User.Login but the mock was incomplete* Create 'reprioritize sub-issue' tool* fixes* use go github pck to add sub-issues* Update to use go github package* update description* update to use go github v73* lint, docs* refactor: tests to use go-github-mock* add toolsnaps* make RemoveSubIssue use NewGitHubAPIErrorResponse, update docstring* Always include SHA in get_file_contents responses (#676)* fix: Add SHA to get_file_contents while preserving MCP behavior (#595)Enhance get_file_contents to include SHA information without changingthe existing MCP server response format.Changes:- Add Contents API call to retrieve SHA before fetching raw content- Include SHA in resourceURI (repo://owner/repo/sha/{SHA}/contents/path)- Add SHA to success messages- Update tests to verify SHA inclusion- Maintain original behavior: text files return raw text, binaries return base64This preserves backward compatibility while providing SHA informationfor better file versioning support.Closes#595* fix: Improve error handling for Contents API responseEnsure response body is properly closed even when an error occurs by movingthe defer statement before the error check. This prevents potential resourceleaks when the Contents API returns an error with a non-nil response.Changes:- Move defer respContents.Body.Close() before error checking- Rename errContents to err for consistency- Add nil check for respContents before attempting to close bodyThis follows Go best practices for handling HTTP responses and preventspotential goroutine/memory leaks.* revert changes to resource URI* use GraphQL API to get file SHA* refactor: mock GQL client instead of getFileSHA function to follow conventions* lint* revert GraphQL---------Co-authored-by: LuluBeatson <lulubeatson@github.com>* Reorganize README, add dedicated install guides, include policies and governance info for the github server (#695)* Refactor README and add host installation guides, governance docs- Reorganized README for clarity and navigation- Added dedicated installation guides for Claude, Cursor, Windsurf, JetBrains, and more- Clarified contribution guidelines and approval criteria- Added policies and governance documentation* Update README.md* Update README with configuration section for remote GitHub MCP Server* Update MCP access policy description in READMERemoving coding agent from the policy note, as the GitHub server is unaffected by this policy* Update configuration steps for GitHub Copilot in JetBrains IDEs......to reflect changes in accessing settings and configuring MCP.* Update install-other-copilot-ides.md* Update Eclipse MCP support version and configuration steps......for GitHub Copilot plugin in installation guide.* Update docs/installation-guides/install-cursor.md* Update docs/installation-guides/install-windsurf.md* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg---------Co-authored-by: Tony Truong <tonytrg@github.com>* fix: shorten long tool name for adding pr review comments (#697)* shorten tool name* update function name to match tool name* adjust wording of descriptions* Update installation guide for GitHub MCP Server (#699)* Update installation guide for GitHub MCP ServerRemoved reference to GitHub.com in the installation guide. The GitHub server is available to Coding Agent by default, without installation needed.* Rename section to 'Install in Other MCP Hosts'Updating title for consistency and adding a link to the "other Copilot IDEs" install guide.* Revise installation guide for Cursor MCP setupUpdated installation guide for Cursor with steps clarified, remote server installation, and one-click install deeplinks to open Cursor and add the github server to the config file.* fix: make mcpcurl support "integer" type (#688)- FYI:https://json-schema.org/understanding-json-schema/reference/numeric#integer* Added installation instructions for mcpcurl (#719)* Added installation instructions for mcpcurl* Update cmd/mcpcurl/README.mdCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Add pagination support to GraphQL-based tools (#683)* initial pagination for `ListDiscussions`* redo category id var cast* add GraphQL pagination support for discussion comments and categories* remove pageinfo returns* fix out ref for linter* update docs* move to unified pagination for consensus on params* update docs* refactor pagination handling* update docs* linter fix* conv rest to gql params for safe lint* add nolint* add error handling for perPage value in ToGraphQLParams* refactor pagination error handling* unified params for rest andn graphql and rennamed to be uniform for golang* add 'after' for pagination* update docs* Update pkg/github/discussions.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update pkg/github/discussions.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update pkg/github/discussions_test.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* update default page size const* reduce default pagination size from 100 to 30 in discussion tests* update pagination for reverse and total* update pagination to remove from discussions* updated README* improve the `ToGraphQLParams` function---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* shorten param descriptions* fix: resp nil check in error handling in RemoveSubIssue function---------Co-authored-by: LuluBeatson <lulubeatson@github.com>Co-authored-by: tommaso-moro <tommaso-moro@github.com>
nickytonline pushed a commit to nickytonline/github-mcp-http that referenced this pull requestOct 4, 2025
* initial pagination for `ListDiscussions`* redo category id var cast* add GraphQL pagination support for discussion comments and categories* remove pageinfo returns* fix out ref for linter* update docs* move to unified pagination for consensus on params* update docs* refactor pagination handling* update docs* linter fix* conv rest to gql params for safe lint* add nolint* add error handling for perPage value in ToGraphQLParams* refactor pagination error handling* unified params for rest andn graphql and rennamed to be uniform for golang* add 'after' for pagination* update docs* Update pkg/github/discussions.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update pkg/github/discussions.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update pkg/github/discussions_test.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* update default page size const* reduce default pagination size from 100 to 30 in discussion tests* update pagination for reverse and total* update pagination to remove from discussions* updated README* improve the `ToGraphQLParams` function---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nickytonline pushed a commit to nickytonline/github-mcp-http that referenced this pull requestOct 4, 2025
* Create 'add sub-issue' tool* Fix hardcoded API host* Create 'list sub-issues' tool* Create 'remove sub-issue' tool* Fix Test_GetIssue mock data - add missing User fieldThe assertion was already checking User.Login but the mock was incomplete* Create 'reprioritize sub-issue' tool* fixes* use go github pck to add sub-issues* Update to use go github package* update description* update to use go github v73* lint, docs* refactor: tests to use go-github-mock* add toolsnaps* make RemoveSubIssue use NewGitHubAPIErrorResponse, update docstring* Always include SHA in get_file_contents responses (github#676)* fix: Add SHA to get_file_contents while preserving MCP behavior (github#595)Enhance get_file_contents to include SHA information without changingthe existing MCP server response format.Changes:- Add Contents API call to retrieve SHA before fetching raw content- Include SHA in resourceURI (repo://owner/repo/sha/{SHA}/contents/path)- Add SHA to success messages- Update tests to verify SHA inclusion- Maintain original behavior: text files return raw text, binaries return base64This preserves backward compatibility while providing SHA informationfor better file versioning support.Closesgithub#595* fix: Improve error handling for Contents API responseEnsure response body is properly closed even when an error occurs by movingthe defer statement before the error check. This prevents potential resourceleaks when the Contents API returns an error with a non-nil response.Changes:- Move defer respContents.Body.Close() before error checking- Rename errContents to err for consistency- Add nil check for respContents before attempting to close bodyThis follows Go best practices for handling HTTP responses and preventspotential goroutine/memory leaks.* revert changes to resource URI* use GraphQL API to get file SHA* refactor: mock GQL client instead of getFileSHA function to follow conventions* lint* revert GraphQL---------Co-authored-by: LuluBeatson <lulubeatson@github.com>* Reorganize README, add dedicated install guides, include policies and governance info for the github server (github#695)* Refactor README and add host installation guides, governance docs- Reorganized README for clarity and navigation- Added dedicated installation guides for Claude, Cursor, Windsurf, JetBrains, and more- Clarified contribution guidelines and approval criteria- Added policies and governance documentation* Update README.md* Update README with configuration section for remote GitHub MCP Server* Update MCP access policy description in READMERemoving coding agent from the policy note, as the GitHub server is unaffected by this policy* Update configuration steps for GitHub Copilot in JetBrains IDEs......to reflect changes in accessing settings and configuring MCP.* Update install-other-copilot-ides.md* Update Eclipse MCP support version and configuration steps......for GitHub Copilot plugin in installation guide.* Update docs/installation-guides/install-cursor.md* Update docs/installation-guides/install-windsurf.md* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg* Apply suggestion from@tonytrg---------Co-authored-by: Tony Truong <tonytrg@github.com>* fix: shorten long tool name for adding pr review comments (github#697)* shorten tool name* update function name to match tool name* adjust wording of descriptions* Update installation guide for GitHub MCP Server (github#699)* Update installation guide for GitHub MCP ServerRemoved reference to GitHub.com in the installation guide. The GitHub server is available to Coding Agent by default, without installation needed.* Rename section to 'Install in Other MCP Hosts'Updating title for consistency and adding a link to the "other Copilot IDEs" install guide.* Revise installation guide for Cursor MCP setupUpdated installation guide for Cursor with steps clarified, remote server installation, and one-click install deeplinks to open Cursor and add the github server to the config file.* fix: make mcpcurl support "integer" type (github#688)- FYI:https://json-schema.org/understanding-json-schema/reference/numeric#integer* Added installation instructions for mcpcurl (github#719)* Added installation instructions for mcpcurl* Update cmd/mcpcurl/README.mdCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Add pagination support to GraphQL-based tools (github#683)* initial pagination for `ListDiscussions`* redo category id var cast* add GraphQL pagination support for discussion comments and categories* remove pageinfo returns* fix out ref for linter* update docs* move to unified pagination for consensus on params* update docs* refactor pagination handling* update docs* linter fix* conv rest to gql params for safe lint* add nolint* add error handling for perPage value in ToGraphQLParams* refactor pagination error handling* unified params for rest andn graphql and rennamed to be uniform for golang* add 'after' for pagination* update docs* Update pkg/github/discussions.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update pkg/github/discussions.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update pkg/github/discussions_test.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* update default page size const* reduce default pagination size from 100 to 30 in discussion tests* update pagination for reverse and total* update pagination to remove from discussions* updated README* improve the `ToGraphQLParams` function---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* shorten param descriptions* fix: resp nil check in error handling in RemoveSubIssue function---------Co-authored-by: LuluBeatson <lulubeatson@github.com>Co-authored-by: tommaso-moro <tommaso-moro@github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@JoannaaKLJoannaaKLJoannaaKL approved these changes

@LuluBeatsonLuluBeatsonAwaiting requested review from LuluBeatson

@omgitsadsomgitsadsAwaiting requested review from omgitsads

Assignees

@mattdhollowaymattdholloway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mattdholloway@JoannaaKL
[8]ページ先頭
©2009-2025 Movatter.jp