- Notifications
You must be signed in to change notification settings - Fork1.4k
simplify environment var with same format UPPERCASE and UNDERSCORE#663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
hungran wants to merge1 commit intogithub:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+2 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Enhance Viper configuration to allow flag names with hyphens to be consumed as environment variables by replacing hyphens with underscores.
- Configure Viper to replace
-with_in env var keys. - Call
viper.SetEnvKeyReplacerbeforeviper.AutomaticEnv().
Comments suppressed due to low confidence (1)
cmd/github-mcp-server/main.go:96
- Consider adding a unit test for initConfig to verify that environment variables with hyphens (e.g., 'dynamic-toolsets') are correctly mapped to underscore format (e.g., 'GITHUB_DYNAMIC_TOOLSETS').
viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_"))Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
This enhance that all argument can be treat as environment variable with standard format from viperhttps://github.com/spf13/viper/blob/master/viper.go#L1400-L1403
eg: given argument flag
dynamic-toolsetscan use asGITHUB_DYNAMIC_TOOLSETS