github/github-mcp-serverPublic

NotificationsYou must be signed in to change notification settings
Fork1.4k
Star17.7k

`get_file_content` Match Paths in Git Tree if Full Path Unknown#650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

LuluBeatson merged 11 commits intomainfromlulu/get-file

Jul 11, 2025

Merged

`get_file_content` Match Paths in Git Tree if Full Path Unknown#650

LuluBeatson merged 11 commits intomainfromlulu/get-file

Jul 11, 2025

+317 −45

Conversation

Copy link

Contributor

LuluBeatson commentedJul 7, 2025•
edited
Loading

Adds additional steps to the end ofget_file_content so that if the provided path wasn't found, then we check the Git Tree for possible matching paths. A path matches if it ends with the provided path.

Changes

Added additional processing to the end ofget_file_content so that if previous attempts to get the file/dir fail, then:
- Get the recursive Git Tree containing tree and blob paths
- Filters the tree for entries matching the inputpath arg. New funcfilterTree.
- If any matches, returns a tool result containing the resolved ref & sha and matching paths. Else resume and return tool error result as normal.
Refactored logic for resolving inputref andsha into a functionresolveGitReference. This still handles refs of the formrefs/tags/{tag},refs/heads/{branch},refs/pull/{pr_number}/head and finds theircommit SHA.
Unit tests for new functionsfilterTree,resolveGitReference.
Update unit tests forGetFileContent to include mocking github client for resolving the git refs.

Examples

File (Unknown Path) from Branch with 2 Matches

get file "server.go" from github/github-mcp-server

File (Unknown Path) from Last Release

get file "server.go" from github/github-mcp-server from the last release

File from Pull Request

get repositories.go from PR #605 in github/github-mcp-server

File from Branch

get repositories.go from the lulu/get-file branch of github/github-mcp-server

TODO

Ensureref is not empty when we callclient.Git.GetTree
Ensure/ are handled properly byfilterPaths. Have unit tests.
Properly formatted errors

add contingency to match path in git tree

3269af4

LuluBeatson added the tool-improvement label

Jul 7, 2025

LuluBeatson added7 commits

July 8, 2025 00:59

resolveGitReference helper

be2f36f

fix: handling of directories

37a6088

Test_filterPaths

588866f

filterPaths - trailing slashes

1cc6f7c

Merge remote-tracking branch 'origin/main' into lulu/get-file

11d8a45

fix: close response body, improve error messages, docs

12c2cfe

update tool result message about resolved git ref

8c40155

LuluBeatson marked this pull request as ready for review

July 8, 2025 12:21

CopilotAI review requested due to automatic review settings

July 8, 2025 12:21

LuluBeatson requested a review froma team as acode owner

July 8, 2025 12:21

CopilotAI reviewed

Jul 8, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enhances theget_file_content function to handle cases where the provided path isn't found by checking the Git tree for possible matching paths that end with the provided path. The implementation includes comprehensive error handling and path resolution improvements.

Refactored Git reference resolution logic into a dedicated function for better maintainability
Added fuzzy path matching using Git tree traversal when exact paths fail
Enhanced test coverage for the new functionality with proper mocking

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
pkg/github/repositories.go	Refactored Git reference resolution, added fuzzy path matching via Git tree, and improved error handling in`GetFileContents`
pkg/github/repositories_test.go	Added comprehensive unit tests for new functions and updated existing tests to include Git reference mocking