Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove redundant param for get_me and update contribution guide#649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tonytrg merged 6 commits intomainfromtonytrg/remove-redundant-param
Jul 7, 2025

Conversation

tonytrg
Copy link
Contributor

@tonytrgtonytrg commentedJul 7, 2025•
edited
Loading

This pr:

  • removes thereason argument forget_me tool call.
  • adds a bit of information to the contribution guide.
  • prompt changes
    • encourage the llm to use this command in a chain if additional information is needed
    • it is unnecesary to tell the llm to not call a tool again which it still has the tool response cached in the session

@CopilotCopilotAI review requested due to automatic review settingsJuly 7, 2025 15:11
@tonytrgtonytrg requested a review froma team as acode ownerJuly 7, 2025 15:11
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR removes the now-unnecessaryreason parameter from theget_me tool and updates related documentation and snapshots.

  • Removed thereason field from the Go tool definition and its snapshot
  • Updated README to indicate no parameters are required
  • Reformatted the CONTRIBUTING guide’s checklist for clarity

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
pkg/github/context_tools.goRemovedmcp.WithString("reason",…) calls inGetMe
pkg/github/toolsnaps/get_me.snapCleared out thereason property in the snapshot
README.mdChanged parameter list to “No parameters required”
CONTRIBUTING.mdConverted hyphenated list to numbered steps and added detail
Comments suppressed due to low confidence (2)

README.md:553

  • [nitpick] Indent the "No parameters required" bullet under theget_me entry so it correctly nests as a sub-item in the markdown list.
  - No parameters required

CONTRIBUTING.md:27

  • [nitpick] Indent these hyphenated sub-steps under step 5 to ensure they render as nested list items in the markdown.
- Run linter: `script/lint`

@tonytrgtonytrg changed the titleTonytrg/remove redundant paramRemove redundant param for get_me and update contribution guideJul 7, 2025
Comment on lines 27 to 29
- Run linter: `script/lint`
- Update snapshots and run tests: `UPDATE_TOOLSNAPS=true go test ./...`
- Update readme documentation: `script/generate-docs`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: indent these so they appear as nested inside step 5

@tonytrgtonytrg merged commit0cf70eb intomainJul 7, 2025
16 checks passed
@tonytrgtonytrg deleted the tonytrg/remove-redundant-param branchJuly 7, 2025 16:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@LuluBeatsonLuluBeatsonLuluBeatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@tonytrg@LuluBeatson
[8]ページ先頭
©2009-2025 Movatter.jp