github/github-mcp-serverPublic

NotificationsYou must be signed in to change notification settings
Fork1.4k
Star17.7k

fix: get_discussion graphQL invalid field#648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

LuluBeatson merged 3 commits intomainfromlulu/get-discussion

Jul 7, 2025

Merged

fix: get_discussion graphQL invalid field#648

LuluBeatson merged 3 commits intomainfromlulu/get-discussion

Jul 7, 2025

Conversation

Copy link

Contributor

LuluBeatson commentedJul 7, 2025•
edited
Loading

Fixes bug inget_discussion which caused tool error and returned:

Field 'state' doesn't exist on type 'Discussion'

Removed "state" field from query and response
Usedgithub.Discussion object instead ofgithub.Issue
Corrected "labels" to "category" in response
Tool arguments and descriptions unchanged.

Before with bug

Now fixed:

LuluBeatson added2 commits

July 7, 2025 13:20

rm State which does not exist on type Discussion

e15b340

update Test_GetDiscussion

12f1278

LuluBeatson changed the title~~Lulu/get discussion~~fix: get_discussion graphQL invalid field

Jul 7, 2025

LuluBeatson marked this pull request as ready for review

July 7, 2025 12:45

CopilotAI review requested due to automatic review settings

July 7, 2025 12:45

LuluBeatson requested a review froma team as acode owner

July 7, 2025 12:45

CopilotAI reviewed

Jul 7, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

The PR fixes the GraphQL query and response handling inget_discussion by removing the invalidstate field and replacing the oldlabels approach with a propercategory mapping.

Removedstate from both query and response struct.
Switched fromgithub.Issue togithub.Discussion return type and updated corresponding fields.
Updated tests to reflect the newDiscussionCategory field instead of labels and state.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/github/discussions.go	Removed`State` field, switched to`github.Discussion`, and mapped`Category` directly.
pkg/github/discussions_test.go	Updated test expectations: changed type to`Discussion`, removed`State`, and asserted on`DiscussionCategory`.

Comments suppressed due to low confidence (2)

pkg/github/discussions.go:215

The function doc comment still refers to returning an issue. Please update any surrounding comments or docs to reflect that this now returns aDiscussion struct rather than anIssue.

discussion := &github.Discussion{

pkg/github/discussions_test.go:270

[nitpick] Consider using a pointer (var out *github.Discussion) when unmarshalling JSON into a pointer type; this aligns with yourexpected pointer and avoids extra dereferencing in assertions.