- Notifications
You must be signed in to change notification settings - Fork1.4k
Graphql toolset#645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Graphql toolset#645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Introducing a new GraphQL toolset to enable arbitrary GraphQL queries against GitHub’s API, including implementation, tests, and documentation.
- Adds a
graphqltoolset in the default group - Implements
ExecuteGraphQLQueryhandler with error categorization - Provides unit/integration tests and updates docs/README
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Addsgraphql toolset toDefaultToolsetGroup |
| pkg/github/graphql_tools.go | ImplementsExecuteGraphQLQuery tool and handler |
| pkg/github/graphql_tools_test.go | Adds unit tests for GraphQL execution scenarios |
| pkg/github/graphql_integration_test.go | Adds integration tests for GraphQL tools |
| docs/remote-server.md | Includes GraphQL in the remote-server tools table |
| docs/graphql-tools.md | Documents the new GraphQL tools and error categories |
| README.md | Adds GraphQL toolset entry |
Comments suppressed due to low confidence (2)
docs/graphql-tools.md:53
- The documentation lists error categories like syntax, field, and type errors, but the implementation only categorizes
rate_limit,authentication,permission,not_found, andexecution_error. Please align the docs with the actualerror_typevalues or extend the implementation accordingly.
- **Syntax errors**: Malformed GraphQL syntaxpkg/github/graphql_tools_test.go:30
- Tests cover successful execution and missing parameters but do not exercise the error categorization branches (rate_limit, authentication, permission, not_found, execution_error). Add tests to simulate these error scenarios and verify the correct
error_typeis set.
tests := []struct {Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Closes: TBD
Similar to the CLI support for running GraphQL queries, I am suggesting in this PR a
GraphQLtoolset which allows agent to compose and run any GraphQL query.Why is GraphQL a good fit for GitHub's MCP?
GraphQL allows discovery and context building:
Based on introspection, the agent can work its way through the schema and find possible ways of exposing information and making changes. This adds lots of unavailable information and actions the agent can't do so far.
Reading more data types
Access to more writing actions
More possibilities with less tools
No need to create a tool for each entity's CRUD operations and every mutations.
Up to date
New additions to the GraphQL schema are available in the MCP when they are released.