- Notifications
You must be signed in to change notification settings - Fork2.7k
Bump go-github to v73.0.0#597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR upgrades thego-github module from v72 to v73 across the codebase, updates third-party license documents accordingly, and adds the new dependency togo.mod.
- Bump all
github.com/google/go-github/v72/githubimports to v73 - Update third-party license entries for the new v73 dependency
- Add
github.com/google/go-github/v73 v73.0.0togo.mod
Reviewed Changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| third-party-licenses.windows.md | Replace v72 license entry with v73 |
| third-party-licenses.linux.md | Replace v72 license entry with v73 |
| third-party-licenses.darwin.md | Replace v72 license entry with v73 |
| pkg/raw/raw_test.go | Update import path for go-github to v73 |
| pkg/raw/raw.go | Update import path for go-github to v73 |
| pkg/github/tools.go | Update import path for go-github to v73 |
| pkg/github/server_test.go | Update import path for go-github to v73 |
| pkg/github/server.go | Update import path for go-github to v73 |
| pkg/github/secret_scanning_test.go | Update import path for go-github to v73 |
| pkg/github/secret_scanning.go | Update import path for go-github to v73 |
| pkg/github/search_utils.go | Update import path for go-github to v73 |
| pkg/github/search_test.go | Update import path for go-github to v73 |
| pkg/github/search.go | Update import path for go-github to v73 |
| pkg/github/repository_resource_test.go | Update import path for go-github to v73 |
| pkg/github/repository_resource.go | Update import path for go-github to v73 |
| pkg/github/repositories_test.go | Update import path for go-github to v73 |
| pkg/github/repositories.go | Update import path for go-github to v73 |
| pkg/github/pullrequests_test.go | Update import path for go-github to v73 |
| pkg/github/pullrequests.go | Update import path for go-github to v73 |
| pkg/github/notifications_test.go | Update import path for go-github to v73 |
| pkg/github/notifications.go | Update import path for go-github to v73 |
| pkg/github/issues_test.go | Update import path for go-github to v73 |
| pkg/github/issues.go | Update import path for go-github to v73 |
| pkg/github/context_tools_test.go | Update import path for go-github to v73 |
| pkg/github/code_scanning_test.go | Update import path for go-github to v73 |
| pkg/github/code_scanning.go | Update import path for go-github to v73 |
| pkg/github/actions_test.go | Update import path for go-github to v73 |
| pkg/github/actions.go | Update import path for go-github to v73 |
| pkg/errors/error_test.go | Update import path for go-github to v73 |
| pkg/errors/error.go | Update import path for go-github to v73 |
| internal/ghmcp/server.go | Update import alias for go-github to v73 |
| go.mod | Addgithub.com/google/go-github/v73 v73.0.0 |
| e2e/e2e_test.go | Update import alias for go-github to v73 |
Noticing I did the same mistake as in#456 (comment)@williammartin - I tried to run it, and it removed all license files and cleared the |
I'd suggest resetting to your first commit and then running |
c16d1cb to978bfa9CompareFixed in978bfa9, it was a local problem with the |
a1baf95 to7c43d5bCompare7c43d5b to29dc859Compare@williammartin fixed the license and now targeting the correct branch ( |
@martinnormark sorry, we backtracked from the next branch 😓 the sync was going to be too hard! |
29dc859 tob53cb1dCompareOk, no worries. Rebased my branch now. You may want to change the CONTRIBUTING.md file if the |
I did, thanks for your vigilance. I updated it thanks to you. ✨ |
Sorry for the churn, just need to update dependabot pkg too and then we can merge. |
tommaso-moro commentedJul 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@martinnormark , this PR is almost ready to be merged (thank you!) It looks like the dependabot.go import is the only blocker here so if you'd like feel free to go ahead and get it updated and then we can merge this :) if not, we're happy to take it from here |
Hi@tommaso-moro - fantastic! I'm currently on vacation with limited access to internet, so if you can move it along that would be great. Thanks! |
be91795 intogithub:mainUh oh!
There was an error while loading.Please reload this page.
* Bump go-github to v73.0.0* Clean up go.mod and update licenses* Updated remaining imports to use github package v73 instead of v72---------Co-authored-by: Tommaso Moro <37270480+tommaso-moro@users.noreply.github.com>Co-authored-by: tommaso-moro <tommaso-moro@github.com>
Decided to make this upgrade in separate PR, instead of mixing with#470