Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add search pull requests tool#583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 5 commits intogithub:mainfromJoannaaKL:add-pr-search
Jun 26, 2025

Conversation

@JoannaaKL
Copy link
Contributor

@JoannaaKLJoannaaKL commentedJun 26, 2025•
edited
Loading

Add search pull requests tool.

Fixes#462 and#334

@JoannaaKLJoannaaKL marked this pull request as ready for reviewJune 26, 2025 09:02
CopilotAI review requested due to automatic review settingsJune 26, 2025 09:02
@JoannaaKLJoannaaKL requested a review froma team as acode ownerJune 26, 2025 09:02
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

Adds a newsearch_pull_requests tool to query GitHub pull requests via the existing search API, wires it into the default toolset, and provides unit tests and snapshots.

  • IntroduceSearchPullRequests inpkg/github/pullrequests.go
  • Register the new tool inDefaultToolsetGroup
  • AddTest_SearchPullRequests and its schema snapshot

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pkg/github/tools.goRegisterSearchPullRequests in the default toolset
pkg/github/pullrequests.goImplementSearchPullRequests function
pkg/github/pullrequests_test.goAddTest_SearchPullRequests unit tests
pkg/github/issues.goUpdate comment forSearchIssues to remove PR mention
pkg/github/toolsnaps/search_pull_requests.snapAdd schema snapshot for the new tool
Comments suppressed due to low confidence (1)

pkg/github/pullrequests_test.go:677

  • Update the expected error message to "failed to search pull requests" to match the implementation's error text.
expectedErrMsg: "failed to search issues",

Add descriptionExtract common codeTest fixesUpdated search descriptionMove search prs to prs toolsetUpdate tools snaps
SamMorrowDrums
SamMorrowDrums previously approved these changesJun 26, 2025
Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome, this is much needed!

JoannaaKL reacted with heart emoji
@SamMorrowDrumsSamMorrowDrums merged commit8bd7152 intogithub:mainJun 26, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Query must include 'is:issue' or 'is:pull-request' onsearch_issues

2 participants

@JoannaaKL@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp