- Notifications
You must be signed in to change notification settings - Fork1.2k
Add a new release workflow#578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
SamMorrowDrums commentedJun 25, 2025
- Updates advice to contributors to merge PRs to next branch
- Adds automation to complain about merging to main.
- Adds a release publishing workflow
👋 Hi there! It looks like this PR is targeting the You can change this by:
Thanks for your contribution! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR introduces a structured release workflow, enforces targeting thenext branch for contributions, and extends Docker publishing triggers.
- Updated contributing guidelines to direct PRs to the
nextbranch. - Added a workflow to block PRs against
mainand prompt authors to switch tonext. - Introduced a manual release workflow (
.github/workflows/release.yml) for tag validation, rebasing, tagging, PR creation, and a summary. - Extended
docker-publish.ymlto run on bothmainandnextbranches.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CONTRIBUTING.md | Added admonition and updated PR submission step to targetnext. |
| .github/workflows/release.yml | New release workflow for validating inputs, rebasing, tagging, PR creation, and summary. |
| .github/workflows/pr-base-check.yml | Workflow to comment on PRs targetingmain, asking to switch tonext. |
| .github/workflows/docker-publish.yml | Extended Docker publish triggers to include thenext branch. |
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:68
- After successfully rebasing
nextontomain, the workflow never pushes the updatednextbranch back to the remote. Add agit push --force-with-lease origin nextstep to ensure the PR includes the rebased commits.
echo "rebase-success=true" >> $GITHUB_OUTPUT.github/workflows/release.yml:134
- The workflow waits for a draft release to appear but never creates one. Introduce a step (e.g.,
gh release create --draft "$TAG") or use an official action to generate the draft release after tagging.
echo "Waiting for GitHub to create the draft release..."e7504a5 to48817edCompare