Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fix e2e tests#536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tonytrg merged 2 commits intomainfromtonytrg/fix-e2e
Jun 18, 2025
Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 14 additions & 21 deletionse2e/e2e_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@ package e2e_test

import (
"context"
"encoding/base64"
"encoding/json"
"fmt"
"net/http"
Expand DownExpand Up@@ -508,17 +507,14 @@ func TestFileDeletion(t *testing.T) {
require.NoError(t, err, "expected to call 'get_file_contents' tool successfully")
require.False(t, resp.IsError, fmt.Sprintf("expected result not to be an error: %+v", resp))

textContent, ok = resp.Content[0].(mcp.TextContent)
require.True(t, ok, "expected content to be of typeTextContent")
embeddedResource, ok:= resp.Content[1].(mcp.EmbeddedResource)
require.True(t, ok, "expected content to be of typeEmbeddedResource")

var trimmedGetFileText struct {
Content string `json:"content"`
}
err = json.Unmarshal([]byte(textContent.Text), &trimmedGetFileText)
require.NoError(t, err, "expected to unmarshal text content successfully")
b, err := base64.StdEncoding.DecodeString(trimmedGetFileText.Content)
require.NoError(t, err, "expected to decode base64 content successfully")
require.Equal(t, fmt.Sprintf("Created by e2e test %s", t.Name()), string(b), "expected file content to match")
// raw api
textResource, ok := embeddedResource.Resource.(mcp.TextResourceContents)
require.True(t, ok, "expected embedded resource to be of type TextResourceContents")

require.Equal(t, fmt.Sprintf("Created by e2e test %s", t.Name()), textResource.Text, "expected file content to match")

Comment on lines +510 to 518
Copy link
Preview

CopilotAIJun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The indexing (resp.Content[1]) and type assertion logic is duplicated in both tests. Consider extracting a helper likegetTextFromEmbedded(resp) to improve readability and reduce duplication.

Copilot uses AI. Check for mistakes.

// Delete the file
deleteFileRequest := mcp.CallToolRequest{}
Expand DownExpand Up@@ -703,17 +699,14 @@ func TestDirectoryDeletion(t *testing.T) {
require.NoError(t, err, "expected to call 'get_file_contents' tool successfully")
require.False(t, resp.IsError, fmt.Sprintf("expected result not to be an error: %+v", resp))

textContent, ok = resp.Content[0].(mcp.TextContent)
require.True(t, ok, "expected content to be of typeTextContent")
embeddedResource, ok:= resp.Content[1].(mcp.EmbeddedResource)
require.True(t, ok, "expected content to be of typeEmbeddedResource")

var trimmedGetFileText struct {
Content string `json:"content"`
}
err = json.Unmarshal([]byte(textContent.Text), &trimmedGetFileText)
require.NoError(t, err, "expected to unmarshal text content successfully")
b, err := base64.StdEncoding.DecodeString(trimmedGetFileText.Content)
require.NoError(t, err, "expected to decode base64 content successfully")
require.Equal(t, fmt.Sprintf("Created by e2e test %s", t.Name()), string(b), "expected file content to match")
// raw api
textResource, ok := embeddedResource.Resource.(mcp.TextResourceContents)
require.True(t, ok, "expected embedded resource to be of type TextResourceContents")

require.Equal(t, fmt.Sprintf("Created by e2e test %s", t.Name()), textResource.Text, "expected file content to match")

Comment on lines +702 to 710
Copy link
Preview

CopilotAIJun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same pattern repeated here inTestDirectoryDeletion. Extracting a shared helper for fetching and validatingTextResourceContents would reduce duplication.

Copilot uses AI. Check for mistakes.

// Delete the directory containing the file
deleteFileRequest := mcp.CallToolRequest{}
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp