Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: enable secret protection#52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
SamMorrowDrums wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromenable-secret-protection

Conversation

SamMorrowDrums
Copy link
Collaborator

Enable checking of repository settings, and add a specific tool for toggling secret scanning settings only.

Screencast.From.2025-03-30.01-30-15.mp4

Advanced Security is a pre-requisite for using this on private repos (and or Secret Protection SKU when it launches next week), so we will need to handle those quirks.

I had to make some manual http calls, because the go wrapper does not wrap this feature.

TODO before merge:

  • decide on cleanest way to handle the public/private repo stuff where there is a pre-requisite to enabling secret protection
  • we could just have a catch-all configuration setting endpoint, with the massive number of possible settings?
  • I can make all fields optional, but the annoying thing is that you can't have push protection on, without secret protection. The API is not conducive to wrapping neatly in a tool, but I must find a way.
  • can we also enable Code Scanning default setup?
  • add tests

@williammartin
Copy link
Collaborator

williammartin commentedApr 23, 2025
edited
Loading

@SamMorrowDrums what do you want to do with this PR?

Should we kick this back to an issue to discuss?

@SamMorrowDrums
Copy link
CollaboratorAuthor

I think this is that issue:

#176

And now that we have the secret protection toolset, I think we can probably proceed.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotAwaiting requested review from CopilotCopilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SamMorrowDrums@williammartin

[8]ページ先頭

©2009-2025 Movatter.jp