- Notifications
You must be signed in to change notification settings - Fork3.3k
Add context toolset and adjust readme#499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR integrates the “context” toolset directly into the default group, removes the standalone initializer, updates server registration, and adjusts documentation to include new and reordered toolsets.
- Move context toolset creation into
DefaultToolsetGroupand dropInitContextToolset - Remove explicit context registration in the server and rely on group registration
- Update README with new toolsets (
context,code_security,notifications,secret_protection) and reorder entries
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/github/tools.go | Inlined context toolset intoDefaultToolsetGroup and removed old init |
| pkg/github/search.go | Added a blank line aftergetClient call |
| internal/ghmcp/server.go | RemovedInitContextToolset usage now handled by the toolset group |
| README.md | Added and reordered toolset entries in documentation table |
Comments suppressed due to low confidence (1)
README.md:150
- Reorder the table entries to match the initialization sequence in
DefaultToolsetGroupso users see the toolsets in the same order they’re registered.
| `context` | **Strongly recommended**: Tools that provide context about the current user and GitHub context you are operating in |Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
95489b2 to1969f25CompareUh oh!
There was an error while loading.Please reload this page.
fe31428 intomainUh oh!
There was an error while loading.Please reload this page.
* add context toolset and adjust readme* move resources to a toolset* add resource registration as a toolset concern* add a note about broadening of toolsets* Apply suggestion from@SamMorrowDrums
Uh oh!
There was an error while loading.Please reload this page.
Adds the missing toolsets to docs, and also makes the context tools a toolset in their own right - as the behaviour is a little strange that it sits outside the toolsets user controls.
As the namespaces concept appears to have more traction that toolsets, we will expand the concept to encompass resources for now, so that you can run multiple servers with different toolsets without a break in functionality.
This change partially aligns us with thenamespaces spec proposal.
Closes:#482