Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add initial conformance test#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
williammartin merged 1 commit intomainfromwm/conformance-test
Mar 28, 2025
Merged

Conversation

@williammartin
Copy link
Collaborator

@williammartinwilliammartin commentedMar 28, 2025•
edited
Loading

Description

Given you have bothgithub/github-mcp-server andmcp/github images available locally.

Requires-tags conformance to avoid pollutinggo test ./... with failures due to missing deps.

A failure looks like:

➜  github-mcp-server git:(wm/conformance-test) ✗ GITHUB_PERSONAL_ACCESS_TOKEN=foo go test -tags conformance -count 1 ./conformance--- FAIL: TestCapabilities (0.57s)    conformance_test.go:121: waiting for anthropic server to start...    conformance_test.go:121: waiting for github server to start...    conformance_test.go:33: sending anthropic: {"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2024-11-05","capabilities":{},"clientInfo":{"name":"ConformanceTest","version":"0.0.1"}}}    conformance_test.go:33: received from anthropic: {"result":{"protocolVersion":"2024-11-05","capabilities":{"tools":{}},"serverInfo":{"name":"github-mcp-server","version":"0.1.0"}},"jsonrpc":"2.0","id":1}    conformance_test.go:33: sending github: {"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2024-11-05","capabilities":{},"clientInfo":{"name":"ConformanceTest","version":"0.0.1"}}}    conformance_test.go:33: received from github: {"jsonrpc":"2.0","id":1,"result":{"protocolVersion":"2024-11-05","capabilities":{"resources":{},"tools":{"listChanged":true}},"serverInfo":{"name":"github-mcp-server","version":"0.0.1"}}}    conformance_test.go:154: capabilities mismatch:        Resources        Tools.ListChanged

Notes

Lots of quality of life improvements to be had, lots of shortcuts taken, lots lots lots.

I tried to use testcontainers first to get some lifecycle management out of the box but it turns outthey don't provide any way to get a handle to stdin.

I know themark3labs module providestypes for us, and probably we'll end up using them, but I was exploring the schema ground up as I was writing this, so it was exploratory for me too.

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think that's great work to get started. I think lettings these evolve and not standing in the way is the best way to get this going, so this is a bit of a LGTM review, but I did glance over all the lines 😅

@williammartin
Copy link
CollaboratorAuthor

williammartin commentedMar 28, 2025•
edited
Loading

Well, the test currently fails so I don't want to merge it but thanks 😬 I'll probably put these behind a build tag.

@SamMorrowDrums
Copy link
Collaborator

Well, the test currently fails so I don't want to merge it but thanks 😬

Yeah I figured you'd fix it first, but whether you do that now, or in multiple PRs to me is secondary.

@williammartinwilliammartinforce-pushed thewm/conformance-test branch 2 times, most recently fromdbe5bd1 to58b3a27CompareMarch 28, 2025 20:38
@williammartinwilliammartin marked this pull request as ready for reviewMarch 28, 2025 20:39
}
}

func diffNonNilFields(a, b interface{}, path string) string {
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't look too closely.

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Avert your eyes.

Copy link
CollaboratorAuthor

@williammartinwilliammartinMar 28, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is call of Cthulhu.

@williammartinwilliammartin merged commit75d71ad intomainMar 28, 2025
13 checks passed
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull requestApr 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@williammartin@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp