- Notifications
You must be signed in to change notification settings - Fork1.4k
Update VS Code config JSON#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@@ -63,33 +63,37 @@ code-insiders | |||
Another way is to set the environment variable in your shell configuration file (e.g., `.bashrc`, `.zshrc`, etc.). | |||
Run **Preferences: Open User Settings (JSON)**,andcreate or append to the `mcp` setting: | |||
Create a new file `.vscode/mcp.json`andprovide this configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we should remove the lines above that mention setting the token as env variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have no strong opinion on that. I didn't want to take away another option that might be in use. It does seem like thisinput
approach should be elevated to a recommended approach at least?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Certainly very happy to get instructions in that don't expose the secret in plain text!
6c0cb46
intomainUh oh!
There was an error while loading.Please reload this page.
Description
It is now possible in VS Code to use
${input:github-pat}
to indicate that the user should be prompted for an input. This helps keep credentials out of settings files.