May 27, 2025 · May 27, 2025 · May 27, 2025 · May 27, 2025 · May 27, 2025
diff --git a/pkg/github/repository_resource.go b/pkg/github/repository_resource.go
 }
 }

 // This should be unreachable because GetContents should return an error if neither file nor directory content is found.
 return nil, errors.New("no repository resource content found")
 }
 }
diff --git a/pkg/github/repository_resource_test.go b/pkg/github/repository_resource_test.go
 requestArgs    map[string]any
 expectError    string
 expectedResult any
 expectedErrMsg string
 }{
 {
 name: "missing owner",
 },
 expectedResult: expectedDirContent,
 },
 {
 name: "no data",
 mockedClient: mock.NewMockedHTTPClient(
 mock.WithRequestMatch(
 mock.GetReposContentsByOwnerByRepoByPath,
 ),
 ),
 requestArgs: map[string]any{
 "owner": []string{"owner"},
 "repo":  []string{"repo"},
 "path":  []string{"src"},
 },
 expectedResult: nil,
 expectError:    "no repository resource content found",
 },
 {
 name: "empty data",
 mockedClient: mock.NewMockedHTTPClient(
 resp, err := handler(context.TODO(), request)

 if tc.expectError != "" {
 require.ErrorContains(t, err, tc.expectedErrMsg)
 require.ErrorContains(t, err, tc.expectError)
 return
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -201,6 +201,7 @@ func RepositoryResourceContentsHandler(getClient GetClientFn) func(ctx context.C
		}
		}

		// This should be unreachable because GetContents should return an error if neither file nor directory content is found.
		return nil, errors.New("no repository resource content found")
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -94,7 +94,6 @@ func Test_repositoryResourceContentsHandler(t *testing.T) {
		requestArgs map[string]any
		expectError string
		expectedResult any
		expectedErrMsg string
		}{
		{
		name: "missing owner",
Expand DownExpand Up		@@ -180,21 +179,6 @@ func Test_repositoryResourceContentsHandler(t *testing.T) {
		},
		expectedResult: expectedDirContent,
		},
		{
		name: "no data",
		mockedClient: mock.NewMockedHTTPClient(
		mock.WithRequestMatch(
		mock.GetReposContentsByOwnerByRepoByPath,
		),
		),
		requestArgs: map[string]any{
		"owner": []string{"owner"},
		"repo": []string{"repo"},
		"path": []string{"src"},
		},
		expectedResult: nil,
		expectError: "no repository resource content found",
Copy link CollaboratorAuthor williammartinMay 27, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Also, this`expectError` field is never actually used because all the tests set`expectedErrorMsg`. Copy link CollaboratorAuthor williammartinMay 27, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Fixed now inhttps://github.com/github/github-mcp-server/pull/445/files#diff-134064f0cd858eb16a795df5143e87363a3ac3bb4c6a58beddf2dbf1fd689ec3R235-R236
		},
		{
		name: "empty data",
		mockedClient: mock.NewMockedHTTPClient(
Expand DownExpand Up		@@ -248,7 +232,7 @@ func Test_repositoryResourceContentsHandler(t *testing.T) {
		resp, err := handler(context.TODO(), request)

		if tc.expectError != "" {
		require.ErrorContains(t, err, tc.expectedErrMsg)
		require.ErrorContains(t, err, tc.expectError)
		return
		}

Expand Down