Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bump mcp-go to 0.30.0#440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
williammartin merged 1 commit intomainfromwm/bump-mcp-go
May 26, 2025
Merged

Bump mcp-go to 0.30.0#440

williammartin merged 1 commit intomainfromwm/bump-mcp-go
May 26, 2025

Conversation

williammartin
Copy link
Collaborator

@williammartinwilliammartin commentedMay 26, 2025•
edited
Loading

Description

Bumpmcp-go to 0.30.0.

There is a breaking change introduced bymark3labs/mcp-go#287. While there are now better patterns, this PR is the simplest path to bump.

E2E tests

➜  github-mcp-server git:(main) ✗ GOMAXPROCS=1 GITHUB_MCP_SERVER_E2E_HOST=https://github.com GITHUB_MCP_SERVER_E2E_TOKEN=$(gh auth token) go test -v -count=1 --tags e2e ./e2e=== RUN   TestGetMe=== PAUSE TestGetMe=== RUN   TestToolsets=== PAUSE TestToolsets=== RUN   TestTags=== PAUSE TestTags=== RUN   TestFileDeletion=== PAUSE TestFileDeletion=== RUN   TestDirectoryDeletion=== PAUSE TestDirectoryDeletion=== RUN   TestRequestCopilotReview=== PAUSE TestRequestCopilotReview=== RUN   TestAssignCopilotToIssue=== PAUSE TestAssignCopilotToIssue=== RUN   TestPullRequestAtomicCreateAndSubmit=== PAUSE TestPullRequestAtomicCreateAndSubmit=== RUN   TestPullRequestReviewCommentSubmit=== PAUSE TestPullRequestReviewCommentSubmit=== RUN   TestPullRequestReviewDeletion=== PAUSE TestPullRequestReviewDeletion=== CONT  TestGetMe    e2e_test.go:80: Building Docker image for e2e tests...    e2e_test.go:163: Starting Stdio MCP client...--- PASS: TestGetMe (8.17s)=== CONT  TestPullRequestReviewDeletion    e2e_test.go:163: Starting Stdio MCP client...    e2e_test.go:1468: Getting current user...    e2e_test.go:1497: Creating repository williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...    e2e_test.go:1521: Creating branch in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...    e2e_test.go:1538: Creating commit with new file in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...    e2e_test.go:1555: Creating pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...    e2e_test.go:1570: Creating pending review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...    e2e_test.go:1588: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...    e2e_test.go:1615: Deleting review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...    e2e_test.go:1621: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...    e2e_test.go:1506: Deleting repository williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748260377305...--- PASS: TestPullRequestReviewDeletion (7.55s)=== CONT  TestPullRequestReviewCommentSubmit    e2e_test.go:163: Starting Stdio MCP client...    e2e_test.go:1223: Getting current user...    e2e_test.go:1252: Creating repository williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1276: Creating branch in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1293: Creating commit with new file in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1322: Creating pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1337: Creating pending review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1358: Adding file review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1378: Adding single line review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1400: Adding multi line review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1416: Submitting review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1430: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...    e2e_test.go:1261: Deleting repository williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748260384857...--- PASS: TestPullRequestReviewCommentSubmit (12.58s)=== CONT  TestPullRequestAtomicCreateAndSubmit    e2e_test.go:163: Starting Stdio MCP client...    e2e_test.go:1063: Getting current user...    e2e_test.go:1092: Creating repository williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748260397417...    e2e_test.go:1116: Creating branch in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748260397417...    e2e_test.go:1133: Creating commit with new file in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748260397417...    e2e_test.go:1162: Creating pull request in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748260397417...    e2e_test.go:1179: Creating and submitting review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748260397417...    e2e_test.go:1193: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748260397417...    e2e_test.go:1101: Deleting repository williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748260397417...--- PASS: TestPullRequestAtomicCreateAndSubmit (6.23s)=== CONT  TestAssignCopilotToIssue    e2e_test.go:163: Starting Stdio MCP client...    e2e_test.go:960: Getting current user...    e2e_test.go:989: Creating repository williammartin/github-mcp-server-e2e-TestAssignCopilotToIssue-1748260403614...    e2e_test.go:1012: Creating issue in williammartin/github-mcp-server-e2e-TestAssignCopilotToIssue-1748260403614...    e2e_test.go:1026: Assigning copilot to issue in williammartin/github-mcp-server-e2e-TestAssignCopilotToIssue-1748260403614...    e2e_test.go:998: Deleting repository williammartin/github-mcp-server-e2e-TestAssignCopilotToIssue-1748260403614...--- PASS: TestAssignCopilotToIssue (4.94s)=== CONT  TestRequestCopilotReview    e2e_test.go:163: Starting Stdio MCP client...    e2e_test.go:812: Getting current user...    e2e_test.go:841: Creating repository williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748260408583...    e2e_test.go:865: Creating branch in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748260408583...    e2e_test.go:882: Creating commit with new file in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748260408583...    e2e_test.go:910: Creating pull request in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748260408583...    e2e_test.go:924: Requesting Copilot review for pull request in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748260408583...    e2e_test.go:936: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748260408583...    e2e_test.go:850: Deleting repository williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748260408583...--- PASS: TestRequestCopilotReview (5.01s)=== CONT  TestDirectoryDeletion    e2e_test.go:163: Starting Stdio MCP client...    e2e_test.go:614: Getting current user...    e2e_test.go:642: Creating repository williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748260413543...    e2e_test.go:666: Creating branch in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748260413543...    e2e_test.go:683: Creating commit with new file in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748260413543...    e2e_test.go:701: Getting file contents in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748260413543...    e2e_test.go:729: Deleting directory in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748260413543...    e2e_test.go:743: Listing commits in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748260413543...    e2e_test.go:777: Getting commit williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748260413543:6bac3d6d1f8aa722fc97892baf55688e54cca8da...    e2e_test.go:651: Deleting repository williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748260413543...--- PASS: TestDirectoryDeletion (5.50s)=== CONT  TestFileDeletion    e2e_test.go:163: Starting Stdio MCP client...    e2e_test.go:422: Getting current user...    e2e_test.go:450: Creating repository williammartin/github-mcp-server-e2e-TestFileDeletion-1748260419058...    e2e_test.go:474: Creating branch in williammartin/github-mcp-server-e2e-TestFileDeletion-1748260419058...    e2e_test.go:491: Creating commit with new file in williammartin/github-mcp-server-e2e-TestFileDeletion-1748260419058...    e2e_test.go:506: Getting file contents in williammartin/github-mcp-server-e2e-TestFileDeletion-1748260419058...    e2e_test.go:534: Deleting file in williammartin/github-mcp-server-e2e-TestFileDeletion-1748260419058...    e2e_test.go:548: Listing commits in williammartin/github-mcp-server-e2e-TestFileDeletion-1748260419058...    e2e_test.go:582: Getting commit williammartin/github-mcp-server-e2e-TestFileDeletion-1748260419058:71f64bbce271a63918fc8966fc589f70c00c2fdd...    e2e_test.go:459: Deleting repository williammartin/github-mcp-server-e2e-TestFileDeletion-1748260419058...--- PASS: TestFileDeletion (5.60s)=== CONT  TestTags    e2e_test.go:163: Starting Stdio MCP client...    e2e_test.go:284: Getting current user...    e2e_test.go:313: Creating repository williammartin/github-mcp-server-e2e-TestTags-1748260424657...    e2e_test.go:330: Creating tag williammartin/github-mcp-server-e2e-TestTags-1748260424657:v0.0.1...    e2e_test.go:360: Listing tags for williammartin/github-mcp-server-e2e-TestTags-1748260424657...    e2e_test.go:393: Getting tag williammartin/github-mcp-server-e2e-TestTags-1748260424657:v0.0.1...    e2e_test.go:322: Deleting repository williammartin/github-mcp-server-e2e-TestTags-1748260424657...--- PASS: TestTags (3.75s)=== CONT  TestToolsets    e2e_test.go:163: Starting Stdio MCP client...--- PASS: TestToolsets (0.18s)PASSok      github.com/github/github-mcp-server/e2e 59.753s

@CopilotCopilotAI review requested due to automatic review settingsMay 26, 2025 11:54
@williammartinwilliammartin requested a review froma team as acode ownerMay 26, 2025 11:54
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates themcp-go dependency to v0.30.0 and refactors all direct accesses ofr.Params.Arguments to the newr.GetArguments() API.

  • Swappedr.Params.Arguments[...] withr.GetArguments()[...] across server, repository, and issue handlers.
  • Updated the test helpercreateMCPRequest signature to accept a genericany arguments payload.
  • Bumpedgithub.com/mark3labs/mcp-go to v0.30.0 ingo.mod.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
pkg/github/server.goReplacedr.Params.Arguments withr.GetArguments() in all helpers.
pkg/github/repositories.goUpdated argument access inPushFiles to useGetArguments().
pkg/github/issues.goChanged pagination params to useGetArguments().
pkg/github/helper_test.goAdjustedcreateMCPRequest to takeany forArguments.
go.modBumpedgithub.com/mark3labs/mcp-go from v0.28.0 to v0.30.0.

@williammartinwilliammartin merged commitd4a0764 intomainMay 26, 2025
16 checks passed
@williammartinwilliammartin deleted the wm/bump-mcp-go branchMay 26, 2025 12:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@williammartin@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp