- Notifications
You must be signed in to change notification settings - Fork899
Alter the description of get-me to reduce redundant repeat calls#411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the description of theget_me tool to note that its output is static unless the user updates their profile, discouraging redundant repeated calls.
- Enhanced tool description in
GetMeto mention caching behavior - Clarified that the response won’t change unless the profile is updated
Uh oh!
There was an error while loading.Please reload this page.
pkg/github/context_tools.go Outdated
| @@ -15,7 +15,7 @@ import ( | |||
| // GetMe creates a tool to get details of the authenticated user. | |||
| func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (tool mcp.Tool, handler server.ToolHandlerFunc) { | |||
| return mcp.NewTool("get_me", | |||
| mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request include \"me\", \"my\"...")), | |||
| mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request include \"me\", \"my\"... the output will not change unless the user changes their profile, so only call this once.")), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[nitpick] Style: replace the ellipsis and run-on sentence with two clear sentences. For example: "... "my". The output remains unchanged unless the user updates their profile, so a single call is sufficient."
| mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION","Get details of the authenticated GitHub user. Use this when a requestinclude\"me\",\"my\"... the output will not change unless the userchanges their profile, so only call this once.")), | |
| mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION","Get details of the authenticated GitHub user. Use this when a requestincludes\"me\" or\"my\". The output will not change unless the userupdates their profile. Therefore, only call this once.")), |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM with copilots suggestions (or at least,includes typo).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
b90eafe toeefc39aCompare50043c3 intomainUh oh!
There was an error while loading.Please reload this page.
A lot of times the get-me tool is called multiple times in a row, which is redundant. This attempts to address this, by explaining to the model it will not be updated normally.