- Notifications
You must be signed in to change notification settings - Fork898
add basic linter workflow#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR introduces a basic linting workflow for Go projects while fixing some linter errors. Key changes include:
- Adding a GitHub Actions workflow (.github/workflows/lint.yaml) that verifies code formatting and dependency integrity.
- Providing a golangci-lint configuration file (.golangci.yml) with standard linters enabled.
- Refactoring code in multiple packages (cmd, pkg) to address linter issues, such as unused parameter handling and minor stylistic improvements.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/lint.yaml | Adds a lint workflow to check Go files and verify dependencies. |
| .golangci.yml | Introduces basic configurations for golangci-lint. |
| cmd/mcpcurl/main.go | Refines import order and updates function signature parameters for unused arguments. |
| pkg/translations/translations.go | Updates function signatures to ignore unused parameters and changes error handling in DumpTranslationKeyMap. |
| cmd/github-mcp-server/main.go | Updates command functions to use underscore for unused arguments and adjusts viper flag binding. |
| pkg/github/*_test.go | Refactors HTTP handler functions to ignore unused request parameters, ensuring cleaner test code. |
| pkg/github/server.go | Ignores an unused parameter in an inline callback, improving consistency. |
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon.Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome, glad to see this housekeeping stuff getting into the project before I embarrass myself too hard 😂
92bceb5 intomainUh oh!
There was an error while loading.Please reload this page.
Context
This PR adds a lint workflow with a basic configuration. It also fixes the initial linter errors it reports.