- Notifications
You must be signed in to change notification settings - Fork897
feat: addgolangci-lint-action
to thelint
workflow#407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I love the simplicity just need to verify it doesn't this miss a couple of the checks from the existing implementation before merging.
williammartin left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@radar07 thanks for doing this but it loses thego mod
checks. Please ensure this still doesgo mod verify
and asserts nothing has changed aftergo mod tidy
.
It's ok to losego fmt
because golangci-lint does include that check.
radar07 commentedMay 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@williammartin I missed this totally. I removed the |
14ed0ce
tob620cc5
Compare2f8c287
intogithub:mainUh oh!
There was an error while loading.Please reload this page.
Closes:#406