Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: addgolangci-lint-action to thelint workflow#407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 3 commits intogithub:mainfromradar07:add-golangci-lint-action
May 19, 2025

Conversation

radar07
Copy link
Contributor

Closes:#406

@radar07radar07 requested a review froma team as acode ownerMay 16, 2025 20:12
Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I love the simplicity just need to verify it doesn't this miss a couple of the checks from the existing implementation before merging.

radar07 reacted with thumbs up emoji
Copy link
Collaborator

@williammartinwilliammartin left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@radar07 thanks for doing this but it loses thego mod checks. Please ensure this still doesgo mod verify and asserts nothing has changed aftergo mod tidy.

It's ok to losego fmt because golangci-lint does include that check.

@radar07
Copy link
ContributorAuthor

radar07 commentedMay 19, 2025
edited
Loading

@williammartin I missed this totally. I removed thego fmt check and addedgolangci-lint step after theRun checks.

SamMorrowDrums reacted with heart emoji

@radar07radar07force-pushed theadd-golangci-lint-action branch from14ed0ce tob620cc5CompareMay 19, 2025 14:11
@SamMorrowDrumsSamMorrowDrums merged commit2f8c287 intogithub:mainMay 19, 2025
9 checks passed
@radar07radar07 deleted the add-golangci-lint-action branchMay 19, 2025 19:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@williammartinwilliammartinwilliammartin requested changes

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addgolangci-lint-action to thelint workflow
3 participants
@radar07@williammartin@SamMorrowDrums

[8]ページ先頭

©2009-2025 Movatter.jp