- Notifications
You must be signed in to change notification settings - Fork1.4k
fix array schemas#37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the array schemas for GitHub API operations by defining explicit object schemas for array items in both file uploads and pull request review comments.
- In pkg/github/repositories.go, the file objects now have a schema with defined properties for path and content.
- In pkg/github/pullrequests.go, a similar schema has been added for comment objects with properties for path, position, and body.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/repositories.go | Added schema for file objects with properties for path/content |
| pkg/github/pullrequests.go | Added schema for comment objects with properties for path, position, and body |
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab.Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I hope this is eventually cleaned up into part of WithArray more naturally, but this is better than failing.
af22499 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Context
This PR adds schemas for the the array items. Without this, we were creating schemas where arrays didn't have their items specified. This caused issues in 4o.