Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Ensure toolsets are configurable via env var#348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

williammartin
Copy link
Collaborator

Description

Fixes#307

Reviewer Notes

You can run the e2e tests and see a failure by adjustingGITHUB_TOOLSETS and running:

GITHUB_MCP_SERVER_E2E_TOKEN=foo go test -v -run  "TestToolsets" --tags e2e ./e2e

@CopilotCopilotAI review requested due to automatic review settingsApril 25, 2025 12:06
@williammartinwilliammartin requested a review froma team as acode ownerApril 25, 2025 12:06
@williammartinwilliammartin linked an issueApr 25, 2025 that may beclosed by this pull request
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR makes toolsets configurable via an environment variable by refactoring the e2e test setup and updating the main server code to correctly unmarshal toolset configurations. Key changes include:

  • Refactoring e2e tests to use sync.Once for token retrieval and Docker image building, along with introducing a ClientOpts mechanism to pass environment variables.
  • Adding a new TestToolsets to validate toolset configuration via the environment variable.
  • Updating the main command to unmarshal the "toolsets" configuration from the environment using viper.UnmarshalKey.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
e2e/e2e_test.goRefactored test setup and added toolset configuration test using new client options.
cmd/github-mcp-server/main.goModified toolset configuration handling to support comma-separated values via environment vars.

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Really neat PR. Loving the tests.

@williammartinwilliammartin merged commit4e26dce intomainApr 25, 2025
16 checks passed
@williammartinwilliammartin deleted the 307-toolset-does-not-exists-using-github_toolsets branchApril 25, 2025 12:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toolset does not exists using GITHUB_TOOLSETS
2 participants
@williammartin@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp