Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve README by including config example forgh-host flag#335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 4 commits intogithub:mainfromrajbos:main
May 8, 2025

Conversation

rajbos
Copy link
Contributor

I could figure out how to configure the MCP server against GitHub Enterprise Server, but it took a couple of tries and debugging as I forgot to include the http schema in the hostname. Adding an example makes it a bit more clear in my opinion, improving the user experience of the server 😄.

@rajbosrajbos requested a review froma team as acode ownerApril 23, 2025 10:16
@williammartin
Copy link
Collaborator

Hey@rajbos thanks for opening this. Instead of doing this (or in addition), do you think we should adjust the server to appendhttps:// if the scheme is unspecified?

@rajbos
Copy link
ContributorAuthor

Adding it automatically also works. For me it helped to be able to see the example of the extra container arguments, helpful if you do not run them all the time. So doing both would be my preference then 😁.

@williammartin
Copy link
Collaborator

Yeh I just have a minor concern because the JSON is still bifurcated between VSCode and Insiders on whether theinput: prompt is supported. Maybe we could adjust this to just demonstrate an amendedenv block?

@rajbos
Copy link
ContributorAuthor

Yeh I just have a minor concern because the JSON is still bifurcated between VSCode and Insiders on whether theinput: prompt is supported. Maybe we could adjust this to just demonstrate an amendedenv block?

I am using the input block in normal VS Code v1.99.3, so it already is available then?

@SamMorrowDrums
Copy link
Collaborator

@rajbos the issue@williammartin was referring to is that the one-click install button doesn't support setting inputs automatically for VScode (it does for insiders) so for now people are getting a configuration that has the PAT in the env block, and not as an input, but that will be fixed after the next VScode release.

rajbos reacted with thumbs up emoji

@chidaozhi
Copy link

chidaozhi commentedApr 25, 2025
edited
Loading

Could you please let me know how to config "-gh-host"?
Is this right?(use in cursor)
"args": [ "run", "-i", "--rm", "-e", "--gh-host=https://xxx.xxx.com/xxx", "GITHUB_PERSONAL_ACCESS_TOKEN", "ghcr.io/github/github-mcp-server" ],

@rajbos
Copy link
ContributorAuthor

Check the changes files in the PR for the example. You now have it as 'name=value', which is not correct.

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A couple of notes, but I agree it's nice to expand the example.

rajbos reacted with thumbs up emoji
rajbosand others added2 commitsMay 6, 2025 22:11
Co-authored-by: Sam Morrow <sammorrowdrums@github.com>
Co-authored-by: Sam Morrow <sammorrowdrums@github.com>
@rajbos
Copy link
ContributorAuthor

LGTM!

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 thanks Rob!

@SamMorrowDrumsSamMorrowDrums merged commit2218adf intogithub:mainMay 8, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@rajbos@williammartin@SamMorrowDrums@chidaozhi

[8]ページ先頭

©2009-2025 Movatter.jp