fix: use anyOf instead of nullable type array#325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

SamMorrowDrums merged 1 commit intomainfromfix-pr-review

Apr 21, 2025

Merged

fix: use anyOf instead of nullable type array#325

SamMorrowDrums merged 1 commit intomainfromfix-pr-review

Apr 21, 2025

Conversation

Copy link

Member

toby commentedApr 21, 2025

Windsurf is erroring on thecreate_pull_request tool because we're using an array of types to make fields nullable. This PR usesanyOf instead and should fix the issue.

Closes:#318

fix: use anyOf instead of nullable type array

e1a25d8

Windsurf is erroring on the `create_pull_request` tool because we'reusing an array of types to make fields nullable. This PR uses `anyOf`instead and should fix the issue.

CopilotAI review requested due to automatic review settings

April 21, 2025 19:15

toby requested a review froma team as acode owner

April 21, 2025 19:15

CopilotAI reviewed

Apr 21, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR addresses an error with the pull request creation tool by updating the JSON schema definitions for nullable types to use the "anyOf" pattern instead of an array of types.

Changes include modifying the fields "position", "line", "side", "start_line", and "start_side" to use the new "anyOf" syntax.
The update aims to resolve errors with Windsurf related to handling nullable types.