- Notifications
You must be signed in to change notification settings - Fork897
Document direct go install from GitHub#303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
williammartin left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR. Mixed feelings on this one. I appreciate having the ease of installation but it also hamstrings us if we want to use temporaryreplace directives in thego.mod (as opposed to hard forking a repository and updating all the paths).
This has caused issues before for the GitHub CLI.
Furthermore, our primary distribution mechanism are the releases and we do things like including build metadata:
Line 17 in8fb4deb
| RUN --mount=type=cache,target=/root/.cache/go-build CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=${VERSION} -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)" \ |
Closes#302.
Documentation improvement to include direct installation from main branch without cloning the repo locally.