- Notifications
You must be signed in to change notification settings - Fork944
fix: update json schema forcreate_pull_request_review#300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -908,30 +908,30 @@ func CreatePullRequestReview(getClient GetClientFn, t translations.TranslationHe | ||
| map[string]interface{}{ | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": []string{"path", "body", "position", "line", "side", "start_line", "start_side"}, | ||
| "properties": map[string]interface{}{ | ||
| "path": map[string]interface{}{ | ||
| "type": "string", | ||
| "description": "path to the file", | ||
| }, | ||
| "position": map[string]interface{}{ | ||
| "type":[]string{"number", "null"}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I tested this continues to work in VSCode There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I appreciate this is aimed at other host applications, but I think if it doesn't break ones that work, then hopefully it is at worst a noop, and at best works with more tools. I'll try another now. | ||
| "description": "position of the comment in the diff", | ||
| }, | ||
| "line": map[string]interface{}{ | ||
| "type":[]string{"number", "null"}, | ||
| "description": "line number in the file to comment on. For multi-line comments, the end of the line range", | ||
| }, | ||
| "side": map[string]interface{}{ | ||
| "type":[]string{"string", "null"}, | ||
| "description": "The side of the diff on which the line resides. For multi-line comments, this is the side for the end of the line range. (LEFT or RIGHT)", | ||
| }, | ||
| "start_line": map[string]interface{}{ | ||
| "type":[]string{"number", "null"}, | ||
| "description": "The first line of the range to which the comment refers. Required for multi-line comments.", | ||
| }, | ||
| "start_side": map[string]interface{}{ | ||
| "type":[]string{"string", "null"}, | ||
| "description": "The side of the diff on which the start line resides for multi-line comments. (LEFT or RIGHT)", | ||
| }, | ||
| "body": map[string]interface{}{ | ||