Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add reviewers parameter to UpdatePullRequest#285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MayorFaj wants to merge21 commits intogithub:main
base:main
Choose a base branch
Loading
fromMayorFaj:feat/259/assign-reviewers

Conversation

MayorFaj
Copy link
Contributor

This pull request introduces the ability to request reviewers when updating a pull request. The changes include updates to theUpdatePullRequest function to handle reviewers, modifications to the test cases to cover the new functionality, and updates to the documentation.

Enhancements toUpdatePullRequest function:

  • Added support for specifying GitHub usernames to request reviews from in theUpdatePullRequest function. (pkg/github/pullrequests.go)[1][2][3]
  • Ensured the function handles cases where no update is needed but reviewers are specified. (pkg/github/pullrequests.go)

Documentation updates:

  • UpdatedREADME.md to include the newreviewers parameter in the documentation for updating pull requests. (README.md)

Test case updates:

  • Added new test cases to cover scenarios with reviewers, including successful updates and failure cases. (pkg/github/pullrequests_test.go)[1][2][3][4][5]

updatereview

Closes:#259

@CopilotCopilotAI review requested due to automatic review settingsApril 15, 2025 23:15
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@MayorFajMayorFaj requested a review froma team as acode ownerApril 17, 2025 11:26
@MayorFajMayorFaj changed the titlefeat: add reviewers parameter to UpdatePullRequest and update testsfeat: add reviewers parameter to UpdatePullRequestApr 19, 2025
JoannaaKL
JoannaaKL previously approved these changesJun 24, 2025
@JoannaaKL
Copy link
Contributor

Hi@MayorFaj, can you please update the pr so we can get it merged? :)

MayorFaj reacted with thumbs up emoji

@MayorFajMayorFaj requested a review fromJoannaaKLJune 25, 2025 20:48
@MayorFaj
Copy link
ContributorAuthor

@JoannaaKL the PR has been updated

@deivyrene
Copy link

@JoannaaKL the PR has been updated

Could you update again because is out-of-date? Great PR!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@juruenjuruenAwaiting requested review from juruen

@SamMorrowDrumsSamMorrowDrumsAwaiting requested review from SamMorrowDrums

@williammartinwilliammartinAwaiting requested review from williammartin

@tobytobyAwaiting requested review from toby

@JoannaaKLJoannaaKLAwaiting requested review from JoannaaKL

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functionality to assign reviewers to pull requests
3 participants
@MayorFaj@JoannaaKL@deivyrene
[8]ページ先頭
©2009-2025 Movatter.jp