Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pre-reqs for docker use: image is public, so docker pull errors likely mean expired token#282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 2 commits intomainfromismith-patch-1
Apr 24, 2025

Conversation

ismith
Copy link
Contributor

To pull the image, you need docker to be logged in to ghcr.io; this PR links in the README to instructions for doing that.

@CopilotCopilotAI review requested due to automatic review settingsApril 15, 2025 16:29
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates the prerequisites section in the README to include instructions for logging into GitHub Container Registry (ghcr.io) for Docker users.

  • Updated the Docker prerequisites to mention ghcr.io authentication.
  • Added a direct link to the GitHub documentation on authenticating with a personal access token.

@SamMorrowDrums
Copy link
Collaborator

Huh, is this correct?@juruen you validated that anonymous docker pull should just work right?

I've also added this to other machines and scripts and had it pull without authentication. I'm wondering what issue you are experiencing here.

@juruen
Copy link
Collaborator

juruen commentedApr 15, 2025
edited
Loading

Huh, is this correct?@juruen you validated that anonymous docker pull should just work right?

@SamMorrowDrums Yup. I validated it in two ways:

  • brand new vm that never did adocker login to any registries
  • docker logout ghcr.io anddocker pull on another vm

See#192 (comment)

Adocker logout ghcr.io helped that user. So maybe users who are logged intoghcr.io with an expired token are experiencing these issues.

@ismith could you try this:

docker logout ghcr.iodocker pull ghcr.io/github/github-mcp-server
SamMorrowDrums reacted with heart emoji

@SamMorrowDrums
Copy link
Collaborator

users who are logged into ghcr.io with a expired token are experiencing these issues.

Your docker registry was so preoccupied with whether or not they could validate your token, they didn't stop to think if they should.

Your scientists were so preoccupied with whether or not they could, they didn't stop to think if they should scene from Jurassic Park

@williammartin
Copy link
Collaborator

@ismith if#282 (comment) is correct, could you update this PR to the effect of "the image is public, so if you're getting errors, it's probably because your token is expired"

ismith reacted with thumbs up emoji

@williammartin
Copy link
Collaborator

Gentle nudge@ismith.

@ismithismith requested a review froma team as acode ownerApril 24, 2025 19:37
@ismithismith changed the titlePre-reqs for docker use include auth to ghcr.ioPre-reqs for docker use: image is public, so docker pull errors likely mean expired tokenApr 24, 2025
@SamMorrowDrumsSamMorrowDrums merged commitf7eff59 intomainApr 24, 2025
16 checks passed
@SamMorrowDrumsSamMorrowDrums deleted the ismith-patch-1 branchApril 24, 2025 19:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

@juruenjuruenAwaiting requested review from juruen

@williammartinwilliammartinAwaiting requested review from williammartin

@tobytobyAwaiting requested review from toby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ismith@SamMorrowDrums@juruen@williammartin

[8]ページ先頭

©2009-2025 Movatter.jp