Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adding SecretScanning Toolset#280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 9 commits intomainfromtonytrg/add-secret-scanning-tools
Apr 17, 2025

Conversation

tonytrg
Copy link
Contributor

@tonytrgtonytrg commentedApr 15, 2025•
edited
Loading

This PR adds:

@tonytrgtonytrgforce-pushed thetonytrg/add-secret-scanning-tools branch fromd31dd8b to6c01bf9CompareApril 16, 2025 14:15
@tonytrgtonytrg marked this pull request as ready for reviewApril 16, 2025 14:22
@CopilotCopilotAI review requested due to automatic review settingsApril 16, 2025 14:22
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces a new secret scanning toolset to the MCP server by adding two new commands: GetSecretScanningAlert and ListSecretScanningAlerts.

  • Integrates secret scanning tools into the toolset initialization in pkg/github/tools.go.
  • Implements secret scanning functionalities in pkg/github/secret_scanning.go with accompanying tests in pkg/github/secret_scanning_test.go.
  • Updates the README.md with usage documentation for the new secret scanning endpoints.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

FileDescription
pkg/github/tools.goRegisters the secret scanning tools into the toolset collection.
pkg/github/secret_scanning_test.goProvides tests ensuring correct behavior of the secret scanning tool handlers.
pkg/github/secret_scanning.goImplements the GetSecretScanningAlert and ListSecretScanningAlerts functions.
README.mdAdds documentation detailing the usage of the new secret scanning tools.

@tonytrgtonytrg changed the titleAdding GetSecretScanningAlert and ListSecretScanningAlertsAdding SecretScanning ToolsetApr 16, 2025
@tonytrg
Copy link
ContributorAuthor

tonytrg commentedApr 16, 2025•
edited
Loading

Did a manual test run:

Can you list me all secret scanning alerts in github/repo that are resolved?A: Query params{  "owner": "github",  "repo": "repo",  "state": "resolved"}[... Returned list of secretalerts, all resolved]Alright give me github/repo alertnumber 196A:Query params{  "owner": "github",  "repo": "repo",  "alertNumber": 196}{"number":196,...}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tonytrgtonytrg self-assigned thisApr 16, 2025
Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this looks great, just a couple of small comments.

tonytrgand others added3 commitsApril 17, 2025 10:11
Co-authored-by: Sam Morrow <info@sam-morrow.com>
…/github-mcp-server into tonytrg/add-secret-scanning-tools
@tonytrg
Copy link
ContributorAuthor

@SamMorrowDrums good eye for product names.

SamMorrowDrums reacted with heart emoji

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work Tony!

@SamMorrowDrumsSamMorrowDrums merged commit7c197f5 intomainApr 17, 2025
16 checks passed
@SamMorrowDrumsSamMorrowDrums deleted the tonytrg/add-secret-scanning-tools branchApril 17, 2025 08:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

@juruenjuruenAwaiting requested review from juruen

@williammartinwilliammartinAwaiting requested review from williammartin

@tobytobyAwaiting requested review from toby

Assignees

@tonytrgtonytrg

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@tonytrg@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp