- Notifications
You must be signed in to change notification settings - Fork899
feat: enterprise host support#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds rudimentary enterprise support by introducing a new "gh-host" parameter, allowing the GitHub MCP server to direct API calls to GitHub Enterprise endpoints.
- Added the "gh-host" persistent flag.
- Bound "gh-host" to viper.
- Updated the GitHub client to use enterprise-specific base and upload URLs when provided.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon.Learn more
Uh oh!
There was an error while loading.Please reload this page.
Awesome! Do think it would make sense to support an env var (in addition to or instead of the flag)? Just because we're using them elsewhere. |
cmd/github-mcp-server/main.go Outdated
| if host := viper.GetString("gh-host"); host != "" { | ||
| parsedURL, err := url.Parse(fmt.Sprintf("https://api.%s/", host)) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse provided GitHub host URL: %w", err) | ||
| } | ||
| uploadURL, err := url.Parse(fmt.Sprintf("https://uploads.%s/", host)) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse provided GitHub host URL: %w", err) | ||
| } | ||
| ghClient.BaseURL = parsedURL | ||
| ghClient.UploadURL = uploadURL | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we can use theWithEnterpriseURLs() function in thegogithub.Client instead?
Yeah, that's easy. I was considering doing so too. Just didn't 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚀
Uh oh!
There was an error while loading.Please reload this page.
647a5e5 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Adds support for a
gh-hostparam so that enterprises work. Tested it out with failing attempt to call localhost:go run cmd/github-mcp-server/main.go stdio --gh-host github.localhostSo the override is working well.