Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

enhancement: add tool to request reviewers for pull requests#265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MayorFaj wants to merge2 commits intogithub:main
base:main
Choose a base branch
Loading
fromMayorFaj:feat/259/assign-func

Conversation

MayorFaj
Copy link
Contributor

This pull request introduces a new feature to request reviewers for a pull request in the GitHub MCP tool. The changes include updates to the documentation, implementation of the new tool, and corresponding tests. Below are the most important changes:

New Feature Implementation:

  • pkg/github/pullrequests.go: Added theRequestPullRequestReviewers function to create a tool for requesting reviewers for a pull request. This includes defining the tool's input schema, extracting parameters, and making the API call to GitHub.

Documentation Updates:

  • README.md: Updated to include documentation for the newrequest_pull_request_reviewers tool, detailing its parameters and usage.[1][2]

Test Cases:

  • pkg/github/pullrequests_test.go: Added tests for the newRequestPullRequestReviewers function to verify the tool definition and various scenarios, including successful requests and error handling.

Server Integration:

  • pkg/github/server.go: Integrated the newRequestPullRequestReviewers tool into the server setup, ensuring it is available for use.

Closes:#259

@CopilotCopilotAI review requested due to automatic review settingsApril 14, 2025 15:06
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@juruen
Copy link
Collaborator

@MayorFaj thank you again for your time working on this project!

I have a suggestion, instead of creating a new tool, we could leverage the existingupdate_pull_request tool to also take the reviewers as an optional parameter.

Is that something that you'd like to explore? Otherwise, I can take a stab at it when I have the time.

Thanks!

@MayorFaj
Copy link
ContributorAuthor

Sure will take a look

@MayorFajMayorFaj changed the titlefeat: add tool to request reviewers for pull requestsenhancement: add tool to request reviewers for pull requestsApr 15, 2025
@MayorFaj
Copy link
ContributorAuthor

@juruen I made a new PR#285. Kindly review when you get the chance to. I am going to close this

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@juruenjuruenAwaiting requested review from juruen

@SamMorrowDrumsSamMorrowDrumsAwaiting requested review from SamMorrowDrums

@williammartinwilliammartinAwaiting requested review from williammartin

@tobytobyAwaiting requested review from toby

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functionality to assign reviewers to pull requests
3 participants
@MayorFaj@juruen@SamMorrowDrums

[8]ページ先頭

©2009-2025 Movatter.jp