Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add token source flag, gh cli auth#231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gillisandrew wants to merge4 commits intogithub:main
base:main
Choose a base branch
Loading
fromgillisandrew:feat-gh-cli-auth

Conversation

gillisandrew
Copy link

@gillisandrewgillisandrew commentedApr 11, 2025•
edited
Loading

This PR adds support for using the GitHub CLI's token. Users pass--token-source gh to enable it (defaulting to "env" token source). It also includes a couple of changes that should make it straightforward to publish a GitHub CLI extension (#215) that uses "gh" as the default source.

@CopilotCopilotAI review requested due to automatic review settingsApril 11, 2025 21:28
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • go.mod: Language not supported

@gillisandrewgillisandrew changed the titlefeat: use existing GitHub CLI token as a fallbackfeat: add token source flag, gh cli authApr 15, 2025
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

cmd/github-mcp-server/main.go:227

  • [nitpick] The variable name 'token_source' does not follow Go naming conventions. Renaming it to 'tokenSource' would improve readability and adhere to idiomatic Go style.
token_source := viper.GetString("token-source")

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@juruenjuruenAwaiting requested review from juruen

@SamMorrowDrumsSamMorrowDrumsAwaiting requested review from SamMorrowDrums

@tobytobyAwaiting requested review from toby

@williammartinwilliammartinAwaiting requested review from williammartin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@gillisandrew@williammartin@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp