- Notifications
You must be signed in to change notification settings - Fork950
Prefer already-defined endpoint mock#226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the test for GetCommit to use the pre-defined endpoint pattern from the mock package, eliminating the redundant manual definition.
- Removed the manually defined endpoint pattern.
- Replaced its usage with mock.GetReposCommitsByOwnerByRepoByRef in test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I missed that too, sorry!
865f9bf intomainUh oh!
There was an error while loading.Please reload this page.
Went to cut a PR upstream and realized I missedthis pre-defined endpoint pattern when checking for work on#216.