- Notifications
You must be signed in to change notification settings - Fork908
Update build from source instructions#224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| + "stdio" | ||
| ], | ||
| "env": { | ||
| "GITHUB_PERSONAL_ACCESS_TOKEN": "${input:github_token} OR <YOUR_TOKEN>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Users shouldn't be hardcoding PATs in a config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I just copied it from the Claude Desktop section. What should it be instead? 🤔 And should I also update it in the Claude Desktop section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh fair enough, vscode supports password inputs which prompts for input when the server is launched. Claude doesn't appear to have that feature.
We ended up going with#264 to clarify source install. Thank you for this though! |
I just updated the description of the
build from sourcesection to make them more clear/obvious.I just thought it make sense because something like this was already requested
#215 which is IMHO more complicate to do than just use plain old
go.There is also this issues (#199) which ask for "Dockerless" solutions.
To me it seems that people needs some more help or guidance.
Let me know what do you think and if I should change something.
P.s.:
I haven't tested it
Just added what I think should work 🙃