Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added get_issue_events , get_issue_timeline and get_issue_event tools#211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
artemsaveliev wants to merge10 commits intogithub:main
base:main
Choose a base branch
Loading
fromartemsaveliev:main

Conversation

artemsaveliev
Copy link

Implements 3 tools dealing with issue events and timeline:

@CopilotCopilotAI review requested due to automatic review settingsApril 10, 2025 06:45
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds three new tools to handle GitHub issue events and timeline retrieval with associated tests and documentation updates.

  • Added tool registrations in the server to support get_issue_timeline, get_issue_events, and get_issue_event.
  • Implemented the corresponding functions in pkg/github/issues.go and added comprehensive tests in pkg/github/issues_test.go.
  • Updated README.md to document the new tools.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
pkg/github/server.goRegisters new tools and adds a helper function for int64 parameter conversion.
pkg/github/issues_test.goProvides tests for the new tools covering success and error scenarios.
pkg/github/issues.goImplements tool functions for issue timeline, events, and a single event retrieval.
README.mdUpdates documentation for the new tools with expected input parameters.
Comments suppressed due to low confidence (2)

README.md:167

  • The parameter name 'perPage' in the documentation does not match the tool definition which uses 'per_page'. Consider updating the README to use consistent naming.
- `perPage`: Results per page (number, optional)

pkg/github/issues_test.go:1434

  • [nitpick] The test for 'get_issue_event' uses an event_id value of 42 while the expected mock event has a different ID (17196710688). Consider aligning the event_id values to avoid potential confusion.
"event_id": float64(42),

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think with the pagination helper and the annotations this is good to merge. The code is great, and I'm curious to see what models do with the tools!

Thanks again@artemsaveliev

@SamMorrowDrums
Copy link
Collaborator

Having lots of fun

image

image

Hmm not convinced it was right:

image

@SamMorrowDrums
Copy link
Collaborator

@artemsaveliev as an update, I have been experimenting - and I have played with tool descriptions and things, and it works for the basic cases, but for more complex cases the models do tend to get stuck and then just keep repeating the same requests ad-infinitum!

@artemsaveliev
Copy link
Author

artemsaveliev commentedMay 23, 2025
edited
Loading

@SamMorrowDrums The getting-stuck-in-a-loop, and more importantly running out of time/context window is more specific to VSCode Agent implementation - it does not work great with large amounts of data.

Specifically, to me the most interesting use case that the timeline tool covers is discovering cross-reference timeline events - this will allow agent to traverse entire set of issues, as long as they contain links to each other.
https://docs.github.com/en/rest/using-the-rest-api/issue-event-types?apiVersion=2022-11-28#cross-referenced
In my testing, the agent gave up after about a minute of navigating links - but again, this is specific to VSCode agent implementation. Other agents, especially the ones that have larger context and/or implementation of "memory", should be able to navigate better.

SamMorrowDrums reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@juruenjuruenAwaiting requested review from juruen

@williammartinwilliammartinAwaiting requested review from williammartin

@tobytobyAwaiting requested review from toby

@SamMorrowDrumsSamMorrowDrumsAwaiting requested review from SamMorrowDrums

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@artemsaveliev@SamMorrowDrums

[8]ページ先頭

©2009-2025 Movatter.jp