Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add ability to view branches for a repo #141#205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
juruen merged 10 commits intogithub:mainfromaryasoni98:issues-141
Apr 11, 2025

Conversation

aryasoni98
Copy link
Contributor

Closes:#141

@aryasoni98
Copy link
ContributorAuthor

Hi@juruen,
Whenever you get a chance, could you please review the PR? Let me know if anything needs to be updated. Appreciate your time!

alexvettithanam-gep

This comment was marked as spam.

@SamMorrowDrums
Copy link
Collaborator

This looks great thank you, I just merged a PR that will require some small updates to this one:#195

@aryasoni98
Copy link
ContributorAuthor

This looks great thank you, I just merged a PR that will require some small updates to this one:#195

Thanks for the heads-up! Just to clarify — could you please specify what small changes are needed following the merge of#195?
Also, I noticed the conflict in pkg/github/server.go — would resolving that be part of the required updates?

Copy link
Collaborator

@juruenjuruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good! Just a little comment about making the test code more consistent with the existing code base.

@aryasoni98aryasoni98 requested a review fromjuruenApril 10, 2025 18:43
Copy link
Collaborator

@juruenjuruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We are almost there! There's just a few lint errors that need to be fixed: we need to make sure we usegithub.Ptr and not the deprecated versions.

@aryasoni98
Copy link
ContributorAuthor

We are almost there! There's just a few lint errors that need to be fixed: we need to make sure we usegithub.Ptr and not the deprecated versions.

@juruen Update the code. Please review the PR .

Copy link
Collaborator

@juruenjuruen left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@aryasoni98 I almost forget, we need to update the README file with the new tool! 🙇

Copy link
Collaborator

@juruenjuruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I believe we are just missing updating the README with the new tool

@aryasoni98aryasoni98 requested a review fromjuruenApril 11, 2025 12:17
@aryasoni98
Copy link
ContributorAuthor

I believe we are just missing updating the README with the new tool

@juruen Update theREADME.md file

Copy link
Collaborator

@juruenjuruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 🚀

Thank you so much for your contribution!

@juruenjuruen merged commit01aefd3 intogithub:mainApr 11, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@juruenjuruenjuruen approved these changes

@SamMorrowDrumsSamMorrowDrumsAwaiting requested review from SamMorrowDrums

@williammartinwilliammartinAwaiting requested review from williammartin

@tobytobyAwaiting requested review from toby

@alexvettithanam-gepalexvettithanam-gepAwaiting requested review from alexvettithanam-gep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to view "branches" for a repo
4 participants
@aryasoni98@SamMorrowDrums@juruen@alexvettithanam-gep
[8]ページ先頭
©2009-2025 Movatter.jp