- Notifications
You must be signed in to change notification settings - Fork899
Update README.md to remove mcp key on .vscode/mcp.json example#186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update README.md to remove mcp key on .vscode/mcp.json example#186
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the README.md to remove the non-required "mcp" key from the VS Code configuration example so that it works across all versions of VS Code.
- Removed the "mcp" key block from the JSON code snippet.
- Updated the configuration example to reflect the current VS Code requirements.
The vscode configuration example in the README.md does not work with my version of vscode. Since it's also not required, this change removes it so that it works in all versions of vscode.Version:```Version: 1.99.1 (Universal)Commit: 7c6fdfb0b8f2f675eb0b47f3d95eeca78962565bDate: 2025-04-04T15:58:59.624Z (4 days ago)Electron: 34.3.2ElectronBuildId: 11161073Chromium: 132.0.6834.210Node.js: 20.18.3V8: 13.2.152.41-electron.0OS: Darwin x64 24.3.0```
dd6e884 tod858f11CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Much better thanks.
f8436ab intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The
.vscode/mcp.jsonconfiguration example in the README.md does not appear to work with the snippet provided. There is a note that indicates that the mcp key is not needed. More specifically, the mcp key needs to be removed for the.vscode/mcp.jsonconfiguration to work. To make things simpler and easier to get started, we provide two example snippets to get started depending on which settings file is used.Before:
After:
Version: