- Notifications
You must be signed in to change notification settings - Fork899
feat: implement Dependabot security update tools#180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
smadi0x86 wants to merge2 commits intogithub:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
feat: implement Dependabot security update tools#180
smadi0x86 wants to merge2 commits intogithub:mainfromsmadi0x86:feat/implement-Dependabot-security-update-tools
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This PR implements tools for managing Dependabot security updates in repositories. However, during implementation, we encountered an issue with GitHub's API behavior where public repositories should have Dependabot alerts enabled by default, but the API still requires explicit enabling of vulnerability alerts. This creates a confusing user experience. We've documented this issue in the code for future investigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
pkg/github/security.go:108
- [nitpick] The use of the parameter name 'vulnerability_alerts' may be misleading since its value is applied to the AdvancedSecurity field. Consider clarifying the parameter name or adding a comment to explain the mapping.
if vulnerabilityAlerts, ok := settings["vulnerability_alerts"].(bool); ok {Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:#176
Description
This PR implements tools for managing Dependabot security updates in repositories. The implementation includes:
GetSecuritySettings- Retrieves security settings for a repositoryUpdateSecuritySettings- Updates security settings for a repositoryGetDependabotSecurityUpdatesStatus- Checks if Dependabot security updates are enabledImplementation Details
During implementation, I encountered an issue with GitHub's API behavior:
As a result, I've:
EnableDependabotSecurityUpdatesandDisableDependabotSecurityUpdatestools for future investigation.