- Notifications
You must be signed in to change notification settings - Fork1.4k
add create_issue tool#18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds a new tool called "create_issue" to enable creating issues in a GitHub repository using a comma-separated list for multi-value fields, along with associated tests and documentation updates.
- Added unit tests for parseCommaSeparatedList and createIssue functionality.
- Introduced the createIssue tool implementation and registered it in the server.
- Updated README documentation to include the new create_issue tool and its parameters.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/server_test.go | Added tests for parseCommaSeparatedList functionality. |
| pkg/github/issues_test.go | Added tests for createIssue tool covering success and failure cases. |
| README.md | Documentation updated for the new create_issue tool and its parameters. |
| pkg/github/issues.go | Added createIssue tool implementation using comma-separated list parsing. |
| pkg/github/server.go | Registered the createIssue tool and provided a local parseCommaSeparatedList. |
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon.Learn more
… juruen/create-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK@juruen can you make an issue to re-visit the CSV style, and use proper JSON RPC arrays once it works?
26e3c6c intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Context
This PR adds atool for creating an issue. We initially postponed this feature to wait formcp-go to support arrays for describing arguments.
The library finally added support for arrays a few days ago. However, my first implementation, which used them, caused issues in VS Code.
Since VS Code is my main test platform, I decided to implement the array using a comma-separated list instead. We can revisit this decision once the issue is resolved.