Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: export remaining + helpers#168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 1 commit intomainfromexport-rest
Apr 8, 2025
Merged

Conversation

SamMorrowDrums
Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums commentedApr 7, 2025
edited
Loading

Export the remaining tool funcs and helpers.

@CopilotCopilotAI review requested due to automatic review settingsApril 7, 2025 22:39
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates several functions and helpers to use exported (capitalized) names so they can be accessed externally. Key changes include renaming search functions and helper methods across multiple GitHub-related packages, and updating associated tests and resource handlers to reflect the new names.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
pkg/github/server_test.goRenamed getMe to GetMe in test cases.
pkg/github/server.goUpdated tool and helper function names to exported names.
pkg/github/search_test.goUpdated search function names to their exported versions.
pkg/github/search.goRenamed search functions and updated with exported WithPagination.
pkg/github/repository_resource_test.goRenamed resource handler functions to exported names.
pkg/github/repository_resource.goUpdated repository resource functions to exported names.
pkg/github/repositories_test.goRenamed file-related functions to exported names in tests.
pkg/github/repositories.goUpdated repository tool functions with exported naming conventions.
pkg/github/pullrequests_test.goRenamed pull request functions to exported names in tests.
pkg/github/pullrequests.goUpdated pull request functions to their exported counterparts.
pkg/github/issues_test.goRenamed issue-related functions to exported names in tests.
pkg/github/issues.goUpdated issue functions to exported names.
pkg/github/code_scanning_test.goRenamed code scanning alert functions to exported names in tests.
pkg/github/code_scanning.goUpdated code scanning functions to exported names.

@SamMorrowDrumsSamMorrowDrums changed the base branch frommain toexport-searchApril 7, 2025 22:43
@SamMorrowDrumsSamMorrowDrums changed the titlechore: export remaining search + helperschore: export remaining + helpersApr 7, 2025
juruen
juruen previously approved these changesApr 8, 2025
Copy link
Collaborator

@juruenjuruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

Base automatically changed fromexport-search tomainApril 8, 2025 07:39
@SamMorrowDrumsSamMorrowDrums dismissedjuruen’sstale reviewApril 8, 2025 07:39

The base branch was changed.

@SamMorrowDrumsSamMorrowDrums merged commit519ed9e intomainApr 8, 2025
13 of 15 checks passed
@SamMorrowDrumsSamMorrowDrums deleted the export-rest branchApril 8, 2025 07:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@juruenjuruenjuruen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SamMorrowDrums@juruen

[8]ページ先頭

©2009-2025 Movatter.jp