Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: export repository funcs#166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 1 commit intomainfromexport-repositories
Apr 8, 2025
Merged

Conversation

SamMorrowDrums
Copy link
Collaborator

Export repository funcs to the public interface.

@CopilotCopilotAI review requested due to automatic review settingsApril 7, 2025 22:29
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates the naming of various repository functions and tool definitions to export them on the public interface.

  • Renamed resource functions from lower-case to exported (capitalized) versions in pkg/github/server.go, pkg/github/repository_resource.go, and corresponding test files.
  • Updated tool functions in pkg/github/repositories.go and pkg/github/repositories_test.go to use capitalized, exported names.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
pkg/github/server.goUpdated calls to resource functions to their exported versions.
pkg/github/repository_resource_test.goUpdated tests to use exported resource handler functions.
pkg/github/repository_resource.goRenamed resource functions and handler to exported names.
pkg/github/repositories_test.goUpdated tests to use exported tool function names.
pkg/github/repositories.goRenamed tool functions to exported names.
Comments suppressed due to low confidence (1)

pkg/github/server.go:59

  • [nitpick] The function 'searchRepositories' remains unexported while other repository functions have been updated to exported versions. Consider renaming it to 'SearchRepositories' for naming consistency if it is meant to be part of the public interface.
s.AddTool(searchRepositories(client, t))

juruen
juruen previously approved these changesApr 8, 2025
Copy link
Collaborator

@juruenjuruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

Base automatically changed fromexport-prs tomainApril 8, 2025 07:33
@SamMorrowDrumsSamMorrowDrums dismissedjuruen’sstale reviewApril 8, 2025 07:33

The base branch was changed.

@SamMorrowDrumsSamMorrowDrums merged commitc1bdd6a intomainApr 8, 2025
13 of 15 checks passed
@SamMorrowDrumsSamMorrowDrums deleted the export-repositories branchApril 8, 2025 07:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@juruenjuruenjuruen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SamMorrowDrums@juruen

[8]ページ先頭

©2009-2025 Movatter.jp