Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Correct lower-case issue state#1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
almaleksia merged 3 commits intomainfromalmaleksia/correct-lower-case-issue-state
Dec 10, 2025

Conversation

@almaleksia
Copy link
Contributor

@almaleksiaalmaleksia commentedDec 10, 2025•
edited
Loading

Upper-casestate,orderBy anddirection parameters because they're often passed as lc which results in an error.

bretthowell714-source and SamMorrowDrums reacted with laugh emojiSamMorrowDrums reacted with heart emoji
@almaleksiaalmaleksia requested a review froma team as acode ownerDecember 10, 2025 13:57
CopilotAI review requested due to automatic review settingsDecember 10, 2025 13:57
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR fixes an issue where thelist_issues tool fails when thestate parameter is provided in lowercase (e.g., "open" or "closed"). The fix addsstrings.ToUpper() to normalize the state value before casting it to thegithubv4.IssueState enum type, which expects uppercase values like "OPEN" and "CLOSED" as defined in the schema.

Key Changes

  • Added uppercase conversion for thestate parameter in theListIssues function to handle lowercase input gracefully

@almaleksiaalmaleksiaforce-pushed thealmaleksia/correct-lower-case-issue-state branch from7199f89 to8f1eb1dCompareDecember 10, 2025 14:16
@almaleksiaalmaleksia merged commitcfd7ef9 intomainDec 10, 2025
16 checks passed
@almaleksiaalmaleksia deleted the almaleksia/correct-lower-case-issue-state branchDecember 10, 2025 16:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@omgitsadsomgitsadsomgitsads approved these changes

+1 more reviewer

@bretthowell714-sourcebretthowell714-sourcebretthowell714-source approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@almaleksia@omgitsads@bretthowell714-source
[8]ページ先頭
©2009-2025 Movatter.jp