Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: milestone read write search CRUD operations#1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
blockedby wants to merge7 commits intogithub:main
base:main
Choose a base branch
Loading
fromblockedby:feat/milestone_read_write

Conversation

@blockedby
Copy link

@blockedbyblockedby commentedDec 8, 2025
edited
Loading

Add milestone CRUD tooling
add search filtering to include creator logins
add creator-lockdown test coverage and wildcard search test
add tests covering creator matching and lockdown behavior for milestones

{3A1B1A83-F8BC-4AAD-95E9-EC4550D4F780}

closes:#258

- Implemented ListMilestones, GetMilestone, and MilestoneWrite functions for managing GitHub milestones.- Added corresponding test cases to ensure functionality and error handling.- Created tool definitions and input schemas for each milestone operation.- Included snapshots for tool definitions to facilitate testing and validation.This update enhances the GitHub integration by allowing users to list, retrieve, create, update, and delete milestones in repositories.
- Updated ListMilestones and GetMilestone functions to incorporate a lockdown mode feature, filtering milestones based on creator access.- Introduced a RepoAccessCache to manage access checks efficiently.- Added new test cases to validate the functionality of the lockdown mode, ensuring proper handling of milestones based on creator permissions.- Adjusted tool definitions to accommodate the new parameters for cache and feature flags.
- Updated milestone test cases to ignore the request parameter in handler functions for improved clarity.- Integrated data sanitization for milestone titles and descriptions to ensure safe handling of user input.- Adjusted the milestone summary function to utilize sanitized values, enhancing security and consistency.
- Added documentation for new milestone management functions: get_milestone, list_milestones, and milestone_write.- Included required parameters and options for each function to improve clarity and usability for developers.
- Implemented the search_milestones function to allow searching for repository milestones based on title and description.- Added input schema and validation for required parameters: owner, repo, and query.- Created test cases to validate the functionality, including success scenarios and error handling for invalid inputs.- Updated README to document the new search_milestones tool and its parameters.- Included snapshots for tool definitions to facilitate testing and validation.
- Introduced new test cases for the SearchMilestones function, including wildcard matching and filtering by creator login.- Enhanced the SearchMilestones implementation to support wildcard queries and creator login matching.- Added a test to verify that lockdown mode correctly blocks milestones created by unsafe users.- Improved query handling by trimming whitespace and allowing for empty queries to match all milestones.
@blockedbyblockedby requested a review froma team as acode ownerDecember 8, 2025 22:55
@blockedbyblockedby changed the titleFeat/milestone read write CRUD operationosfeat: milestone read write search CRUD operationsDec 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@blockedby

[8]ページ先頭

©2009-2025 Movatter.jp