- Notifications
You must be signed in to change notification settings - Fork899
chore: pass version through to server#155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
A chore PR to wire the version parameter through the server initialization.
- Updated the server constructor in pkg/github/server.go to accept a version parameter instead of a hard-coded value.
- Updated the instantiation call in cmd/github-mcp-server/main.go to pass the version received from configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/server.go | Changed the NewServer function signature to include a version parameter in place of "0.0.1". |
| cmd/github-mcp-server/main.go | Modified the call to NewServer to pass the version variable rather than a hard-coded value. |
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab.Learn more
7ab5d96 intomainUh oh!
There was an error while loading.Please reload this page.
Just noticed that this was not wired up, and it should be. The server has a version param that was still hard-coded.